Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Puustinen, Ismo" <ismo.puustinen@intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3] python3: make readline and gdbm support conditional.
Date: Wed, 14 Jun 2017 09:59:57 +0000	[thread overview]
Message-ID: <1497434396.3184.4.camel@intel.com> (raw)
In-Reply-To: <CAJTo0LaFN78k690wh=tLVDzQ54NFmcwitaKczFU=ZoCwsre+1Q@mail.gmail.com>

On Tue, 2017-06-13 at 20:36 +0100, Burton, Ross wrote:
> If gdbm isn't present then the gdbm package isn't generated at all,
> which is as expected.  python3-readline just contains the rlcompleter
> package which is basically an implementation detail and could
> arguably be deleted in a do_install_append that checks the
> PACKAGECONFIG.

So, if I understand this correctly, you want to have this
do_install_append?

> The provides/depends will be needed still though, unless we teach the
> manifest generator that some packages depend on PACKAGECONFIG flags.

I was thinking the same. Changing the manifest generator might be
cleaner than "patching" the manifest file like this. However, it would
split the changes into three places: the recipe itself, the manifest
generator, and the generated manifest file. This would make it more
difficult for someone reading the recipe to understand how the
mechanism works. Anyway, please tell how you would like me to proceed
here: do you want to have the patch as it is done now or do you want to
see the generator changed?

Ismo

      reply	other threads:[~2017-06-14  9:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  7:43 [PATCH v3] python3: make readline and gdbm support conditional Ismo Puustinen
2017-06-13 19:36 ` Burton, Ross
2017-06-14  9:59   ` Puustinen, Ismo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497434396.3184.4.camel@intel.com \
    --to=ismo.puustinen@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox