From: Patrick Ohly <patrick.ohly@intel.com>
To: Tom Rini <trini@konsulko.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] image: Fix "metadata is not deterministic" when chaining 2+ CONVERSION_CMDs
Date: Wed, 26 Jul 2017 07:57:06 +0200 [thread overview]
Message-ID: <1501048626.26603.23.camel@intel.com> (raw)
In-Reply-To: <1501012689-2574-1-git-send-email-trini@konsulko.com>
On Tue, 2017-07-25 at 15:58 -0400, Tom Rini wrote:
> When we have more than one CONVERSION_CMD being used, for example
> ext4.gz.sha256sum we will see errors about "metadata is not
> deterministic". This is because we do not have a stable order of
> intermediate files that will be removed in the generated shell
> command.
> We fix this by calling sorted() on the set of rm_tmp_images so that
> we
> will have a stable hash again.
>
> Cc: Patrick Ohly <patrick.ohly@intel.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Acked-by: Patrick Ohly <patrick.ohly@intel.com>
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2017-07-26 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 19:58 [PATCH] image: Fix "metadata is not deterministic" when chaining 2+ CONVERSION_CMDs Tom Rini
2017-07-26 5:57 ` Patrick Ohly [this message]
2017-09-15 7:41 ` Martin Hundebøll
2017-09-15 12:16 ` Tom Rini
2017-09-15 18:20 ` Martin Hundebøll
2017-09-19 9:08 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501048626.26603.23.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox