Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Röjfors" <richard.rojfors@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] package_manager: Fix support for NO_RECOMMENDATONS
Date: Sun, 30 Jul 2017 10:39:37 +0200	[thread overview]
Message-ID: <1501403977.9238.2.camel@gmail.com> (raw)

When support for dnf was introduced the check of the
no NO_RECOMMENDATIONS variable got broken.
    
This fixes the issue by compairing to the string "1"
rather than the number 1.
    
Signed-off-by: Richard Röjfors <richard@puffinpack.se>
---
diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index 72503eb9d3..518cf8dbe3 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -585,7 +585,7 @@ class RpmPM(PackageManager):
 
         output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
                          (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
-                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) +
+                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) +
                          (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) +
                          ["install"] +
                          pkgs)


             reply	other threads:[~2017-07-30  8:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-30  8:39 Richard Röjfors [this message]
2017-07-30  9:01 ` ✗ patchtest: failure for package_manager: Fix support for NO_RECOMMENDATONS Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501403977.9238.2.camel@gmail.com \
    --to=richard.rojfors@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox