From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] sstatetests: limit the number of signature comparisons when differ
Date: Mon, 07 Aug 2017 12:19:18 -0500 [thread overview]
Message-ID: <1502126358.2330.5.camel@linux.intel.com> (raw)
In-Reply-To: <CAJTo0LbdWuxLS=4VKHbUZ_rcTrBk0MpJB78i11HbCnBmScm6CA@mail.gmail.com>
On Mon, 2017-08-07 at 18:05 +0100, Burton, Ross wrote:
> On 7 August 2017 at 18:06, Leonardo Sandoval
> <leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> yes, but we this way, we are not listing those > 20 and I
> believe this
> is important. This fix just diffsigs the first 20, and the
> rest are just
> listed for convenience.
>
>
> Good point. You could neatly print the filenames in one iteration,
> and then the first 20 diffs in another loop.
not super convinced but yes, that can be a another way to avoid the if
inside the for body. I will send a v2.
Leo
>
>
> also, sets are not 'subscriptable' thus slicing is not
> possible on sets.
>
>
> Which is why I called list() before slicing.
>
>
> Ross
prev parent reply other threads:[~2017-08-07 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 18:57 [PATCH 1/2] sstatetests: Use python function instead of bitbake-diffsigs script leonardo.sandoval.gonzalez
2017-08-04 18:57 ` [PATCH 2/2] sstatetests: limit the number of signature comparisons when differ leonardo.sandoval.gonzalez
2017-08-07 16:32 ` Burton, Ross
2017-08-07 17:06 ` Leonardo Sandoval
2017-08-07 17:05 ` Burton, Ross
2017-08-07 17:19 ` Leonardo Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502126358.2330.5.camel@linux.intel.com \
--to=leonardo.sandoval.gonzalez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox