From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 01/10] oeqa/targetcontrol.py: simplify checking for qemu_use_kvm
Date: Tue, 08 Aug 2017 16:30:46 +0100 [thread overview]
Message-ID: <1502206246.18633.250.camel@linuxfoundation.org> (raw)
In-Reply-To: <2e63bf95e8a5288464d90567260047217a3617d0.1501494496.git.liezhi.yang@windriver.com>
On Mon, 2017-07-31 at 02:50 -0700, Robert Yang wrote:
> The "if qemu_use_kvm" is not needed.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/lib/oeqa/targetcontrol.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/lib/oeqa/targetcontrol.py
> b/meta/lib/oeqa/targetcontrol.py
> index 3255e3a5c63..11e6c820e85 100644
> --- a/meta/lib/oeqa/targetcontrol.py
> +++ b/meta/lib/oeqa/targetcontrol.py
> @@ -132,9 +132,8 @@ class QemuTarget(BaseTarget):
> dump_host_cmds = d.getVar("testimage_dump_host")
> dump_dir = d.getVar("TESTIMAGE_DUMP_DIR")
> qemu_use_kvm = d.getVar("QEMU_USE_KVM")
> - if qemu_use_kvm and \
> - (qemu_use_kvm == "True" and "x86" in d.getVar("MACHINE") or \
> - d.getVar("MACHINE") in qemu_use_kvm.split()):
> + if qemu_use_kvm == "True" and "x86" in d.getVar("MACHINE") or \
> + d.getVar("MACHINE") in qemu_use_kvm.split():
> use_kvm = True
> else:
> use_kvm = False
>
It is needed since qemu_use_kvm could be None and None.split() will
cause an error.
Cheers,
Richard
next prev parent reply other threads:[~2017-08-08 15:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 9:50 [PATCH 00/10] Revive ptest and add result to buildhistory Robert Yang
2017-07-31 9:50 ` [PATCH 01/10] oeqa/targetcontrol.py: simplify checking for qemu_use_kvm Robert Yang
2017-08-08 15:30 ` Richard Purdie [this message]
2017-08-09 9:46 ` Robert Yang
2017-08-21 8:02 ` Robert Yang
2017-08-21 20:35 ` Richard Purdie
2017-08-22 1:08 ` Robert Yang
2017-08-09 9:46 ` Robert Yang
2017-07-31 9:50 ` [PATCH 02/10] runtime/cases/_ptest.py: revive it Robert Yang
2017-07-31 13:38 ` Paul Eggleton
2017-08-01 2:03 ` Robert Yang
2017-07-31 9:50 ` [PATCH 03/10] oeqa/utils/logparser.py: add skip status Robert Yang
2017-07-31 9:50 ` [PATCH 04/10] runtime/cases/_ptest.py: " Robert Yang
2017-07-31 9:50 ` [PATCH 05/10] runtime/cases/_ptest.py: rename it to ptest.py Robert Yang
2017-07-31 9:50 ` [PATCH 06/10] utils/logparser.py: fix section check Robert Yang
2017-07-31 9:50 ` [PATCH 07/10] core/target/ssh.py: replace decode errors Robert Yang
2017-07-31 9:50 ` [PATCH 08/10] buildhistory.bbclass: print message when no commit Robert Yang
2017-07-31 9:50 ` [PATCH 09/10] buildhistory.bbclass: add ptest_log Robert Yang
2017-07-31 13:30 ` Paul Eggleton
2017-08-01 1:50 ` Robert Yang
2017-07-31 9:50 ` [PATCH 10/10] testimage.bbclass: update comments Robert Yang
2017-07-31 13:41 ` [PATCH 00/10] Revive ptest and add result to buildhistory Paul Eggleton
2017-08-01 6:47 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502206246.18633.250.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox