Re: [PATCH v3 2/2] sstatetests: limit the number of signature comparisons when differ

[Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>]

On Tue, 2017-08-08 at 15:40 +0100, Burton, Ross wrote:
> On 7 August 2017 at 22:33,
> <leonardo.sandoval.gonzalez@linux.intel.com> wrote:
>         From: Leonardo Sandoval
>         <leonardo.sandoval.gonzalez@linux.intel.com>
>         
>         For perfomance reasons, limit the number of signature
>         comparisons when
>         stamps differ. The limit set is hardcoded to 20.
>         
>         [YOCTO #11651]
>         
>         Signed-off-by: Leonardo Sandoval
>         <leonardo.sandoval.gonzalez@linux.intel.com>
>         ---
>          meta/lib/oeqa/selftest/cases/sstatetests.py | 40
>         +++++++++++++++++++----------
>          1 file changed, 26 insertions(+), 14 deletions(-)
>         
>         diff --git a/meta/lib/oeqa/selftest/cases/sstatetests.py
>         b/meta/lib/oeqa/selftest/cases/sstatetests.py
>         index 0b36027918..6298443a18 100644
>         --- a/meta/lib/oeqa/selftest/cases/sstatetests.py
>         +++ b/meta/lib/oeqa/selftest/cases/sstatetests.py
>         @@ -458,6 +458,25 @@ http_proxy = "http://example.com/"
>                              base = os.sep.join(root.rsplit(os.sep,
>         2)[-2:] + [name])
>                              f[base] = shash
>                      return f
>         +
>         +        def compare_sigfiles(files, files1, files2,
>         compare=False):
>         +            for k in files:
>         +                if k in files1 and k in files2:
>         +                    i_sigfile += 1
> 
> 
> Surely this is going to produce an i_sigfile is not defined error?

Right, I forgot to remove that line and test it properly. Will send
another revision.

Leo



> 
> 
> Ross