From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark D Horn <mark.d.horn@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] recipetool: create: allow handers to set license
Date: Thu, 10 Aug 2017 11:00:39 +0100 [thread overview]
Message-ID: <1502359239.18633.274.camel@linuxfoundation.org> (raw)
In-Reply-To: <1501715385-17089-1-git-send-email-mark.d.horn@intel.com>
On Wed, 2017-08-02 at 16:09 -0700, Mark D Horn wrote:
> Recipetool plugins set through register_recipe_handlers were not able
> to impact the license type via setting extravalues['LICENSE']. This
> is
> due to caching the license variables in create_recipe before the
> handlers
> have been executed.
>
> This change moves the call to handle_license_vars well after the
> registered plugins (and extravalue functions) have been called.
>
> Signed-off-by: Mark D Horn <mark.d.horn@intel.com>
> ---
> scripts/lib/recipetool/create.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I'm afraid this leads to oe-selftest regressions and issues in devtool:
$ oe-selftest -r devtool.DevtoolTests.test_devtool_add
[...]
2017-08-10 10:58:01,398 - oe-selftest - INFO - ======================================================================
2017-08-10 10:58:01,399 - oe-selftest - INFO - FAIL [6.404s]: test_devtool_add (devtool.DevtoolTests)
2017-08-10 10:58:01,399 - oe-selftest - INFO - ----------------------------------------------------------------------
2017-08-10 10:58:01,399 - oe-selftest - INFO - Traceback (most recent call last):
File "/media/build1/poky/meta/lib/oeqa/core/decorator/__init__.py", line 32, in wrapped_f
return func(*args, **kwargs)
File "/media/build1/poky/meta/lib/oeqa/selftest/cases/devtool.py", line 206, in test_devtool_add
result = runCmd('devtool add pv %s' % srcdir)
File "/media/build1/poky/meta/lib/oeqa/utils/commands.py", line 191, in runCmd
raise AssertionError("Command '%s' returned non-zero exit status %d:\n%s" % (command, result.status, exc_output))
AssertionError: Command 'devtool add pv /tmp/devtoolqaznmpqyo4/pv-1.5.3' returned non-zero exit status 1:
NOTE: Starting bitbake server...
NOTE: Creating workspace layer in /media/build1/poky/build/workspace
NOTE: Enabling workspace layer in bblayers.conf
NOTE: Starting bitbake server...
NOTE: Starting bitbake server...
ERROR: Traceback (most recent call last):
File "/media/build1/poky/bitbake/lib/bb/command.py", line 83, in runCommand
result = command_method(self, commandline)
File "/media/build1/poky/bitbake/lib/bb/command.py", line 566, in parseRecipeFile
envdata = parser.loadDataFull(fn, appendfiles)
File "/media/build1/poky/bitbake/lib/bb/cache.py", line 339, in loadDataFull
bb_data = self.load_bbfile(virtualfn, appends, virtonly=True)
File "/media/build1/poky/bitbake/lib/bb/cache.py", line 352, in load_bbfile
datastores = parse_recipe(bb_data, bbfile, appends, mc)
File "/media/build1/poky/bitbake/lib/bb/cache.py", line 315, in parse_recipe
bb_data = bb.parse.handle(bbfile, bb_data)
File "/media/build1/poky/bitbake/lib/bb/parse/__init__.py", line 113, in handle
return h['handle'](fn, data, include)
File "/media/build1/poky/bitbake/lib/bb/parse/parse_py/BBHandler.py", line 157, in handle
return ast.multi_finalize(fn, d)
File "/media/build1/poky/bitbake/lib/bb/parse/ast.py", line 395, in multi_finalize
finalize(fn, d)
File "/media/build1/poky/bitbake/lib/bb/parse/ast.py", line 355, in finalize
bb.utils.better_exec("\n".join(code), {"d": d})
File "/media/build1/poky/bitbake/lib/bb/utils.py", line 399, in better_exec
exec(code, get_context(), context)
File "<code>", line 3, in <module>
File "/media/build1/poky/meta/classes/base.bbclass", line 468, in __anon_686__media_build1_poky_meta_classes_base_bbclass
File "/media/build1/poky/bitbake/lib/bb/__init__.py", line 104, in fatal
raise BBHandledException()
bb.BBHandledException
ERROR: Parsing newly created recipe failed, moving recipe to /media/build1/poky/build/workspace/recipes/pv/pv_1.5.3.bb.parsefailed for reference. If this looks to be caused by the recipe itself, please report this error.
----------------------------------------------------------------------
2017-08-10 10:58:01,399 - oe-selftest - INFO - Ran 1 test in 7.684s
2017-08-10 10:58:01,399 - oe-selftest - INFO - FAILED
2017-08-10 10:58:01,399 - oe-selftest - INFO - (failures=1)
2017-08-10 10:58:01,404 - oe-selftest - INFO - RESULTS:
2017-08-10 10:58:01,405 - oe-selftest - INFO - RESULTS - devtool.DevtoolTests.test_devtool_add - Testcase 1159: FAILED
2017-08-10 10:58:01,405 - oe-selftest - INFO - SUMMARY:
2017-08-10 10:58:01,405 - oe-selftest - INFO - oe-selftest () - Ran 1 test in 7.690s
2017-08-10 10:58:01,405 - oe-selftest - INFO - oe-selftest - FAIL - Required tests failed
There were other failures but this one seem to illustrate the issue.
Cheers,
Richard
next prev parent reply other threads:[~2017-08-10 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 23:09 [PATCH] recipetool: create: allow handers to set license Mark D Horn
2017-08-10 10:00 ` Richard Purdie [this message]
2017-08-17 23:35 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502359239.18633.274.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.d.horn@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox