From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] rootfs-postcommands.bbclass: Filter out dangling symlinks in ssh_allow_empty_password()
Date: Mon, 14 Aug 2017 09:30:05 +0100 [thread overview]
Message-ID: <1502699405.13978.2.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170809164518.35834-1-raj.khem@gmail.com>
On Wed, 2017-08-09 at 09:45 -0700, Khem Raj wrote:
> In images built with pam in DISTRO_FEATURES, we end up with dangling
> symlinks
> if su is not packaged into image
>
> $ ls /mnt/a/oe/build/tmp/work/raspberrypi3-bec-linux-gnueabi/core-
> image-minimal/1.0-r0/rootfs/etc/pam.d/su-l -l
> lrwxrwxrwx 1 kraj users 2 Aug 9 07:56
> /mnt/a/oe/build/tmp/work/raspberrypi3-bec-linux-gnueabi/core-image-
> minimal/1.0-r0/rootfs/etc/pam.d/su-l -> su
>
> This causes image do_rootfs to fail
>
> >
> > sed: can't read /mnt/a/oe/build/tmp/work/raspberrypi3-bec-linux-
> > gnueabi/core-image-minimal/1.0-r0/rootfs/etc/pam.d/s
> u-l: No such file or directory
> >
> > WARNING: /mnt/a/oe/build/tmp/work/raspberrypi3-bec-linux-
> > gnueabi/core-image-minimal/1.0-r0/temp/run.ssh_allow_empty_
> password.19238:1 exit 2 from 'sed -i 's/nullok_secure/nullok/'
> /mnt/a/oe/build/tmp/work/raspberrypi3-bec-linux-gnueabi
> /core-image-minimal/1.0-r0/rootfs/etc/pam.d/*'
>
> Therefore we need to filter out dangling symlinks before sed'ing
> things out
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/classes/rootfs-postcommands.bbclass | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
This caused all rootfs sanity tests to fail in lsb images (for all
arches):
https://autobuilder.yocto.io/builders/nightly-x86-lsb/builds/410
https://autobuilder.yocto.io/builders/nightly-x86-64-lsb/builds/408
https://autobuilder.yocto.io/builders/nightly-ppc-lsb/builds/407
https://autobuilder.yocto.io/builders/nightly-mips-lsb/builds/394
https://autobuilder.yocto.io/builders/nightly-arm-lsb/builds/406
(I've confirmed dropping this patch made this issue go away)
Cheers,
Richard
prev parent reply other threads:[~2017-08-14 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 16:45 [PATCH] rootfs-postcommands.bbclass: Filter out dangling symlinks in ssh_allow_empty_password() Khem Raj
2017-08-14 8:30 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502699405.13978.2.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox