From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mail.openembedded.org (Postfix) with ESMTP id D0F0C78385 for ; Wed, 16 Aug 2017 15:51:25 +0000 (UTC) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2017 08:51:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,383,1498546800"; d="scan'208";a="140386398" Received: from lsandov1-mobl2.zpn.intel.com ([10.219.128.134]) by fmsmga005.fm.intel.com with ESMTP; 16 Aug 2017 08:51:26 -0700 Message-ID: <1502899215.28941.50.camel@linux.intel.com> From: Leonardo Sandoval To: Markus Lehtonen Date: Wed, 16 Aug 2017 11:00:15 -0500 In-Reply-To: <716364F9-E9E1-4941-97FA-90D9434E518E@linux.intel.com> References: <20170815214002.55130-1-leonardo.sandoval.gonzalez@linux.intel.com> <62f0c732-87f3-9af6-3380-b9fd863f216c@windriver.com> <716364F9-E9E1-4941-97FA-90D9434E518E@linux.intel.com> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] gpg_sign: perform rpm signing serially X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 15:51:26 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2017-08-16 at 15:28 +0300, Markus Lehtonen wrote: > I agree. I don't see reason for dropping parallelism completely. There is a real gain when running on beefier machines. Making it configurable would probably be best. Or just drop it to a saner value, like 20 or 10. > - Markus > I ran some tests with 100, 20 and 1 and I saw (I can rerun and provide times) no difference on times. gpg may be intrinsically serial so passing 1 or N files wont make much difference in type. The only gain when using file chunks is that one one process is launched. I the other hand, I tried using multiprocessing.Pool, but failed miserably due to file looking reasons. > On 16/08/2017, 2.53, "Mark Hatle" wrote: > > It would probably be better if this was configurable with a 'safe' default. > > Moving from parallel to single will greatly affect the overall performance on > larger build machines (lots of memory and cores) that can handle the load vs a > typical development machine. > > --Mark > > On 8/15/17 4:40 PM, leonardo.sandoval.gonzalez@linux.intel.com wrote: > > From: Leonardo Sandoval > > > > gpg signing in file batches (which was default to 100) is a memory expensive > > computation, causing trouble in some host machines (even on production AB > > as seen on the bugzilla ID). Also, in terms of performance, there is no real > > gain when rpm signing is done in batches. Considering the latter issues, perform the > > rpm signing serially. > > > > Log showing errors observed recently at AB workers: > > > > | gpg: signing failed: Cannot allocate memory > > | gpg: signing failed: Cannot allocate memory > > | error: gpg exec failed (2) > > | /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/build/tmp/work/core2-64-poky-linux/base-passwd/3.5.29-r0/deploy-rpms/core2_64/base-passwd-dev-3.5.29-r0.core2_64.rpm: > > > > [YOCTO #11914] > > > > Signed-off-by: Leonardo Sandoval > > --- > > meta/lib/oe/gpg_sign.py | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/meta/lib/oe/gpg_sign.py b/meta/lib/oe/gpg_sign.py > > index f4d8b10e4b..5c7985a856 100644 > > --- a/meta/lib/oe/gpg_sign.py > > +++ b/meta/lib/oe/gpg_sign.py > > @@ -45,9 +45,9 @@ class LocalSigner(object): > > if fsk_password: > > cmd += "--define '_file_signing_key_password %s' " % fsk_password > > > > - # Sign in chunks of 100 packages > > - for i in range(0, len(files), 100): > > - status, output = oe.utils.getstatusoutput(cmd + ' '.join(files[i:i+100])) > > + # Sign packages > > + for f in files: > > + status, output = oe.utils.getstatusoutput(cmd + ' ' + f) > > if status: > > raise bb.build.FuncFailed("Failed to sign RPM packages: %s" % output) > > > > > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > >