Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] grub2: fix build with gcc-7
Date: Tue, 22 Aug 2017 11:22:09 +0100	[thread overview]
Message-ID: <1503397329.32591.79.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170821205721.20086-2-Martin.Jansa@gmail.com>

On Mon, 2017-08-21 at 22:57 +0200, Martin Jansa wrote:
> * build with gcc-7 fails with:
>   | ./config-util.h:1504:48: error: this use of "defined" may not
> be   portable [-Werror=expansion-to-defined]
>   |              || (defined _FORTIFY_SOURCE && 0 < _FORTIFY_SOURCE \
>   |                                                 ^~~~~~~~~~~~~~~
>   and we're not building on Apple or BSD, so we should be able
>   to just ignoreit until it's resolved properly in some newer gnulib
>   and imported from gnulib to grub-2
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-bsp/grub/grub-efi_2.02.bb | 6 ++++++
>  1 file changed, 6 insertions(+)

Sadly this appears to break grub-efi everywhere on the autobuilder,
e.g.:

https://autobuilder.yocto.io/builders/nightly-no-x11/builds/428/steps/BuildImages/logs/stdio

I took a risk and tried to get this into M3 buts its not paid off and
we'll need another rebuild :(.

Cheers,

Richard




  parent reply	other threads:[~2017-08-22 10:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 20:57 [PATCH 1/2] squashfs: fix build with glibc-2.26 Martin Jansa
2017-08-21 20:57 ` [PATCH 2/2] grub2: fix build with gcc-7 Martin Jansa
2017-08-21 23:52   ` Khem Raj
2017-08-22 17:21     ` Martin Jansa
2017-08-22 17:28       ` Khem Raj
2017-08-22 22:10       ` [PATCHv2] grub2: fix build on gcc where _FORTIFY_SOURCE is defined Martin Jansa
2017-08-22 10:22   ` Richard Purdie [this message]
2017-08-22 10:26     ` [PATCH 2/2] grub2: fix build with gcc-7 Martin Jansa
2017-08-22 10:28       ` Richard Purdie
2017-08-22 16:32     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503397329.32591.79.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox