Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Anders Darander <anders@chargestorm.se>,
	Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] insane: add qa check for uppercase recipe name
Date: Tue, 29 Aug 2017 11:30:16 +0100	[thread overview]
Message-ID: <1504002616.32591.323.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170829082014.ncc3tkyjrlurnkbm@ad.chargestorm.se>

On Tue, 2017-08-29 at 10:20 +0200, Anders Darander wrote:
> Hi,
> 
> * Yeoh Ee Peng <ee.peng.yeoh@intel.com> [170829 04:11]:
> 
> > 
> > Since we disabled uppercase characters in overrides a few releases
> > ago, uppercase characters in recipe names (and for that matter,
> > distro
> > and machine names) cannot be supported due to their reliance upon
> > overrides including the name.
> > 
> > QA check will produce an warning message when it verify that recipe
> > name is uppercase.
> > 
> > [YOCTO# 11592]
> Could you add QA checks also for uppercase in machine and distro
> names?
> 
> When giving an on-site training last winter (using Morty), I helped
> the
> customer solve quite a few issues stemming from the fact that they
> had a
> machine name with uppercase letters in.
> 
> I know that the bug in question specifically talks about recipe name,
> though adding checks for them all would be even better, IMHO.

I'd just note that such checks would belong somewhere else like
sanity.bbclass rather than here (we can check once per config, not per
recipe).

Cheers,

Richard


  reply	other threads:[~2017-08-29 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 19:02 [PATCH] insane: add qa check for uppercase recipe name Yeoh Ee Peng
2017-08-29  8:20 ` Anders Darander
2017-08-29 10:30   ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-17 20:40 Yeoh Ee Peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504002616.32591.323.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=anders@chargestorm.se \
    --cc=ee.peng.yeoh@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox