From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mail.openembedded.org (Postfix) with ESMTP id 1BBAA782BC for ; Thu, 31 Aug 2017 22:41:00 +0000 (UTC) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 31 Aug 2017 15:41:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,455,1498546800"; d="scan'208";a="896038990" Received: from swold-mobl2.jf.intel.com ([10.254.126.139]) by FMSMGA003.fm.intel.com with ESMTP; 31 Aug 2017 15:40:58 -0700 Message-ID: <1504219258.27472.330.camel@linux.intel.com> From: Saul Wold To: openembedded-core@lists.openembedded.org, richard.purdie@linuxfoundation.org Date: Thu, 31 Aug 2017 15:40:58 -0700 X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Subject: [PATCH][resend] insane.bbclass: Warn if ${COREBASE}/LICENSE is used X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 22:41:01 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The top level LICENSE file is not actually a license, it refers other licenses that are used by Bitbake and Meta-data. Relying on this file could cause problems for recipes when this file changes, which it is about to. Signed-off-by: Saul Wold ---  meta/classes/insane.bbclass | 6 +++++-  1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 479d39c..6d20eb6 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -659,7 +659,7 @@ python populate_lic_qa_checksum() {          sane = package_qa_handle_error("license-checksum", pn + ": Recipe file fetches files and does not have license file information (LIC_FILES_CHKSUM)", d)        srcdir = d.getVar('S') - +    corebase_licensefile = d.getVar('COREBASE') + "/LICENSE"      for url in lic_files.split():          try:              (type, host, path, user, pswd, parm) = bb.fetch.decodeurl(url) @@ -670,6 +670,10 @@ python populate_lic_qa_checksum() {          if not os.path.isfile(srclicfile):              package_qa_handle_error("license-checksum", pn + ": LIC_FILES_CHKSUM points to an invalid file: " + srclicfile, d)              continue +         +        if (srclicfile == corebase_licensefile): +            bb.warn("${COREBASE}/LICENSE is not a valid license file, please use '${COMMON_LICENSE_DIR}/MIT' for a MIT License file in LIC_FILES_CHKSUM") +            bb.warn("This will become an error in the next release")            recipemd5 = parm.get('md5', '')          beginline, endline = 0, 0 --  2.7.5