From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ola x Nilsson <ola.x.nilsson@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
Subject: Re: [PATCH 2/2] externalsrc.bbclass: Avoid symlink clashes for virtclasses
Date: Wed, 13 Sep 2017 11:41:44 +0100 [thread overview]
Message-ID: <1505299304.18640.40.camel@linuxfoundation.org> (raw)
In-Reply-To: <1505215422363.98035@axis.com>
On Tue, 2017-09-12 at 11:23 +0000, Ola x Nilsson wrote:
> I noticed that the preceding commit has been merged.
> Is there some problem with this one?
Its not something I can describe easily, more a gut feeling that is
shared by some others I've talked to.
Basically externalsrc is turning into an ever more complicated pile of
corner cases and it worries me a lot. I can't help thinking we really
want to simplify and streamline this, not add more complexity to it.
How exactly we do that I'm not sure, I haven't had the time to spend
looking at the code. I do appreciate you added a test case though.
I guess what might help would be creating standard API in lib/oe to get
things like the remapped name.
I'm actually tempted to throw out he externalsrc symlinks stuff. If our
directory layout is so bad we really should fix that "properly" and
that's something I'm thinking about for the next development cycle...
Cheers,
Richard
next prev parent reply other threads:[~2017-09-13 10:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 14:58 [PATCH 1/2] oeqa/selftest/case: Add recipeinc method Ola x Nilsson
2017-08-28 14:58 ` [PATCH 2/2] externalsrc.bbclass: Avoid symlink clashes for virtclasses Ola x Nilsson
2017-09-12 11:23 ` Ola x Nilsson
2017-09-13 10:41 ` Richard Purdie [this message]
2017-09-13 11:26 ` Ola x Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505299304.18640.40.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=ola.x.nilsson@axis.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox