Re: [PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

Ming Liu
2017-10-13T07:35:20Z

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

Sorry, I mistakenly sent a useless file xxxxxxxxxx file with this patch,
please ignore it, will send a V2 soon.

//Ming Liu

2017-10-13 15:25 GMT+08:00 <liu.ming50@gmail.com>:

> From: Ming Liu <liu.ming50@gmail.com>
>
> A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
> the default terminal, when I run any of the tasks:
> bitbake busybox -c menuconfig/devshell/devpyshell
> bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>
> I got a error as follows:
> "Failed to execute child process "oe-gnome-terminal-phonehome" (No such
> file or directory)"
>
> Seems the environment of the process calling Popen is not passed to the
> child process, this behaviour is a known issue in Python bug tracker:
> http://bugs.python.org/issue8557
>
> It could be fixed by using an absolute path instead per test.
>
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
> meta/lib/oe/terminal.py | 2 +-
> xxxxxxxxxx | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> create mode 100644 xxxxxxxxxx
>
> diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
> index 9eb19a2..94afe39 100644
> --- a/meta/lib/oe/terminal.py
> +++ b/meta/lib/oe/terminal.py
> @@ -224,7 +224,7 @@ def spawn(name, sh_cmd, title=None, env=None, d=None):
> import time
> pidfile = tempfile.NamedTemporaryFile(delete = False).name
> try:
> - sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
> + sh_cmd = bb.utils.which(os.getenv('PATH'),
> "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
> pipe = terminal(sh_cmd, title, env, d)
> output = pipe.communicate()[0]
> if output:
> diff --git a/xxxxxxxxxx b/xxxxxxxxxx
> new file mode 100644
> index 0000000..e69de29
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 2613 bytes --]