Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: openembedded-core@lists.openembedded.org
Subject: Re: [meta][PATCH 1/2] Fix some issues in the fitImage generation
Date: Wed, 25 Oct 2017 12:06:27 +0100	[thread overview]
Message-ID: <1508929587.13607.68.camel@andred.net> (raw)
In-Reply-To: <1508926407.13607.53.camel@andred.net>

On Wed, 2017-10-25 at 11:13 +0100, André Draszik wrote:
> On Wed, 2017-10-25 at 09:32 +0200, Thomas Perrot wrote:
> > - Bad image type replacement for aarch64
> > - Fix DTB path in fitimage.its
> 
> It doesn't look like the DTB bit is still relevant in this commit.
> 
> > - Ignore fitImage type in do_bundle_initramfs task because the packaging
> > is made by do_assemble_fitimage_initramfs
> > - the images for arm64 are not compressed the linux_comp variable must
> > therefore be none
> 
> I think it would also make sense to split this into multiple commits, as
> your aarch64 fixes and fitimage fixes aren't directly related.

To be more clear, your fix to kernel.bbclass is independent of everything
else and doesn't apply to aarch64 only, so it should be a separate commit.


Cheers,
Andre'



  reply	other threads:[~2017-10-25 11:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25  7:32 [meta][PATCH 1/2] Fix some issues in the fitImage generation Thomas Perrot
2017-10-25  7:32 ` [meta][PATCH 2/2] Avoid a circular dependency between do_concat_dtb and do_assemble_fitimage Thomas Perrot
2017-10-25  8:05 ` ✗ patchtest: failure for "[meta] Fix some issues in the ..." and 1 more Patchwork
2017-10-25 10:13 ` [meta][PATCH 1/2] Fix some issues in the fitImage generation André Draszik
2017-10-25 11:06   ` André Draszik [this message]
2017-10-26  4:18     ` Thomas PERROT
     [not found]       ` <BL2PR02MB21633D3A250997F82D3496E0B9570@BL2PR02MB2163.namprd02.prod.outlook.com>
2017-11-10 10:30         ` André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508929587.13607.68.camel@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox