Re: [PATCH v5 3/3] weston: Bump version to 3.0.0

[Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>]

On Tue, 2017-10-17 at 18:59 -0400, Denys Dmytriyenko wrote:
> On Tue, Oct 17, 2017 at 08:31:10AM -0200, Otavio Salvador wrote:
> > Em 17 de out de 2017 6:21 AM, "Fabien Lahoudere" <
> > fabien.lahoudere@collabora.co.uk> escreveu:
> > 
> > On Mon, 2017-10-16 at 21:34 +0100, Burton, Ross wrote:
> > 
> > On 16 October 2017 at 18:30, Otavio Salvador <otavio.salvador@ossystems.
> > com.br> wrote:
> > 
> > 
> > > +          file://weston-gl-renderer-Set-pitch-correctly-for-subsampled-textures.patch
> > 
> > \
> > > +          file://fix-missing-header.patch \
> > 
> > Those should be documented on commit log
> > 
> > 
> > 
> > Agreed.  The missing header one should say what platform causes it to be a
> > problem (in case it never gets upstreamed and someone tests it again on
> > just glibc).  And is the pitch patch sufficiently broken that we need to
> > backport it?
> > 
> > 
> > Without the pitch patch, all applications generating YUV420 will not be
> > displayed correctly. For example "gstlaunch1.0 testvideosrc ! waylandsink"
> > fail.
> > I can keep this patch in a bbappend if you don't want it. Just tell me.
> > 
> > 
> > Please keep the patch. It fixes a issue and it is not BSP specific, so it
> > belongs to core. Just explain it on commit log.
> 
> I don't have a very strong objection here, but it sounds like a corner case 
> for one of the formats. Plus what's the difference between "fail" and "not 
> displayed correctly"?
> 

"fail" means not display correctly but the issue can also lead to a weston crash.

> 
> > For the header patch, I will improve commit message.
> > 
> > I see there is an OVERRIDE libc-musl, should I use this patch in
> > SRC_URI_libc-musl?
> > 
> > 
> > No, just mention it on commit log...
> > 
> > 
> > 
> > Ross
> > 
> > -- 
> > 
> > Fabien
> > 
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > -- 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
-- 
Fabien