* [PATCH] dhcp: fix build issue with libxml2 support
@ 2017-10-25 16:03 Awais Belal
2017-10-25 16:35 ` ✗ patchtest: failure for " Patchwork
2017-11-06 10:47 ` [PATCH] " Belal, Awais
0 siblings, 2 replies; 4+ messages in thread
From: Awais Belal @ 2017-10-25 16:03 UTC (permalink / raw)
To: openembedded-core
A missing case breaks the build when libxml2 is
required and found appropriately. The third argument
to the function AC_SEARCH_LIB is action-if-found which
was mistakenly been used for the case where the library
is not found and hence breaks the configure phase
where it shoud actually pass.
We now pass on silently when action-if-found is
executed.
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
...correct-the-intention-for-xml2-lib-search.patch | 35 ++++++++++++++++++++++
meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb | 1 +
2 files changed, 36 insertions(+)
create mode 100644 meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
diff --git a/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch b/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
new file mode 100644
index 0000000000..6ded764d0e
--- /dev/null
+++ b/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
@@ -0,0 +1,35 @@
+From 501543b3ef715488a142e3d301ff2733aa33eec7 Mon Sep 17 00:00:00 2001
+From: Awais Belal <awais_belal@mentor.com>
+Date: Wed, 25 Oct 2017 21:00:05 +0500
+Subject: [PATCH] dhcp: correct the intention for xml2 lib search
+
+A missing case breaks the build when libxml2 is
+required and found appropriately. The third argument
+to the function AC_SEARCH_LIB is action-if-found which
+was mistakenly been used for the case where the library
+is not found and hence breaks the configure phase
+where it shoud actually pass.
+We now pass on silently when action-if-found is
+executed.
+
+Signed-off-by: Awais Belal <awais_belal@mentor.com>
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index bfe988a..f0459e6 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -608,7 +608,7 @@ AC_ARG_WITH(libxml2,
+ with_libxml2="$withval", with_libxml2="no")
+
+ if test x$with_libxml2 != xno; then
+- AC_SEARCH_LIBS(xmlTextWriterStartElement, [xml2],
++ AC_SEARCH_LIBS(xmlTextWriterStartElement, [xml2],,
+ [if test x$with_libxml2 != xauto; then
+ AC_MSG_FAILURE([*** Cannot find xmlTextWriterStartElement with -lxml2 and libxml2 was requested])
+ fi])
+--
+2.11.1
+
diff --git a/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb b/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
index 4634a01b04..6615ae2555 100644
--- a/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
+++ b/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
@@ -11,6 +11,7 @@ SRC_URI += "file://0001-define-macro-_PATH_DHCPD_CONF-and-_PATH_DHCLIENT_CON.pat
file://0009-remove-dhclient-script-bash-dependency.patch \
file://0010-build-shared-libs.patch \
file://0011-Moved-the-call-to-isc_app_ctxstart-to-not-get-signal.patch \
+ file://0012-dhcp-correct-the-intention-for-xml2-lib-search.patch \
"
SRC_URI[md5sum] = "afa6e9b3eb7539ea048421a82c668adc"
--
2.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ patchtest: failure for dhcp: fix build issue with libxml2 support
2017-10-25 16:03 [PATCH] dhcp: fix build issue with libxml2 support Awais Belal
@ 2017-10-25 16:35 ` Patchwork
2017-11-06 10:47 ` [PATCH] " Belal, Awais
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-10-25 16:35 UTC (permalink / raw)
To: Belal, Awais; +Cc: openembedded-core
== Series Details ==
Series: dhcp: fix build issue with libxml2 support
Revision: 1
URL : https://patchwork.openembedded.org/series/9485/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence_format]
Suggested fix Add Upstream-Status: <Valid status> to the header of meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
Standard format Upstream-Status: <Valid status>
Valid status Pending, Accepted, Backport, Denied, Inappropriate [reason], Submitted [where]
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dhcp: fix build issue with libxml2 support
2017-10-25 16:03 [PATCH] dhcp: fix build issue with libxml2 support Awais Belal
2017-10-25 16:35 ` ✗ patchtest: failure for " Patchwork
@ 2017-11-06 10:47 ` Belal, Awais
2017-11-07 14:46 ` Burton, Ross
1 sibling, 1 reply; 4+ messages in thread
From: Belal, Awais @ 2017-11-06 10:47 UTC (permalink / raw)
To: openembedded-core@lists.openembedded.org
ping!
BR,
Awais
________________________________________
From: Belal, Awais
Sent: Wednesday, October 25, 2017 9:03 PM
To: openembedded-core@lists.openembedded.org
Cc: Belal, Awais
Subject: [PATCH] dhcp: fix build issue with libxml2 support
A missing case breaks the build when libxml2 is
required and found appropriately. The third argument
to the function AC_SEARCH_LIB is action-if-found which
was mistakenly been used for the case where the library
is not found and hence breaks the configure phase
where it shoud actually pass.
We now pass on silently when action-if-found is
executed.
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
...correct-the-intention-for-xml2-lib-search.patch | 35 ++++++++++++++++++++++
meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb | 1 +
2 files changed, 36 insertions(+)
create mode 100644 meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
diff --git a/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch b/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
new file mode 100644
index 0000000000..6ded764d0e
--- /dev/null
+++ b/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
@@ -0,0 +1,35 @@
+From 501543b3ef715488a142e3d301ff2733aa33eec7 Mon Sep 17 00:00:00 2001
+From: Awais Belal <awais_belal@mentor.com>
+Date: Wed, 25 Oct 2017 21:00:05 +0500
+Subject: [PATCH] dhcp: correct the intention for xml2 lib search
+
+A missing case breaks the build when libxml2 is
+required and found appropriately. The third argument
+to the function AC_SEARCH_LIB is action-if-found which
+was mistakenly been used for the case where the library
+is not found and hence breaks the configure phase
+where it shoud actually pass.
+We now pass on silently when action-if-found is
+executed.
+
+Signed-off-by: Awais Belal <awais_belal@mentor.com>
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index bfe988a..f0459e6 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -608,7 +608,7 @@ AC_ARG_WITH(libxml2,
+ with_libxml2="$withval", with_libxml2="no")
+
+ if test x$with_libxml2 != xno; then
+- AC_SEARCH_LIBS(xmlTextWriterStartElement, [xml2],
++ AC_SEARCH_LIBS(xmlTextWriterStartElement, [xml2],,
+ [if test x$with_libxml2 != xauto; then
+ AC_MSG_FAILURE([*** Cannot find xmlTextWriterStartElement with -lxml2 and libxml2 was requested])
+ fi])
+--
+2.11.1
+
diff --git a/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb b/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
index 4634a01b04..6615ae2555 100644
--- a/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
+++ b/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
@@ -11,6 +11,7 @@ SRC_URI += "file://0001-define-macro-_PATH_DHCPD_CONF-and-_PATH_DHCLIENT_CON.pat
file://0009-remove-dhclient-script-bash-dependency.patch \
file://0010-build-shared-libs.patch \
file://0011-Moved-the-call-to-isc_app_ctxstart-to-not-get-signal.patch \
+ file://0012-dhcp-correct-the-intention-for-xml2-lib-search.patch \
"
SRC_URI[md5sum] = "afa6e9b3eb7539ea048421a82c668adc"
--
2.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dhcp: fix build issue with libxml2 support
2017-11-06 10:47 ` [PATCH] " Belal, Awais
@ 2017-11-07 14:46 ` Burton, Ross
0 siblings, 0 replies; 4+ messages in thread
From: Burton, Ross @ 2017-11-07 14:46 UTC (permalink / raw)
To: Belal, Awais; +Cc: openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 3955 bytes --]
No Upstream-Status in the patch, can you add that please.
Ross
On 6 November 2017 at 10:47, Belal, Awais <Awais_Belal@mentor.com> wrote:
> ping!
>
> BR,
> Awais
>
> ________________________________________
> From: Belal, Awais
> Sent: Wednesday, October 25, 2017 9:03 PM
> To: openembedded-core@lists.openembedded.org
> Cc: Belal, Awais
> Subject: [PATCH] dhcp: fix build issue with libxml2 support
>
> A missing case breaks the build when libxml2 is
> required and found appropriately. The third argument
> to the function AC_SEARCH_LIB is action-if-found which
> was mistakenly been used for the case where the library
> is not found and hence breaks the configure phase
> where it shoud actually pass.
> We now pass on silently when action-if-found is
> executed.
>
> Signed-off-by: Awais Belal <awais_belal@mentor.com>
> ---
> ...correct-the-intention-for-xml2-lib-search.patch | 35
> ++++++++++++++++++++++
> meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb | 1 +
> 2 files changed, 36 insertions(+)
> create mode 100644 meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-
> the-intention-for-xml2-lib-search.patch
>
> diff --git a/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-
> the-intention-for-xml2-lib-search.patch b/meta/recipes-connectivity/
> dhcp/dhcp/0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
> new file mode 100644
> index 0000000000..6ded764d0e
> --- /dev/null
> +++ b/meta/recipes-connectivity/dhcp/dhcp/0012-dhcp-correct-
> the-intention-for-xml2-lib-search.patch
> @@ -0,0 +1,35 @@
> +From 501543b3ef715488a142e3d301ff2733aa33eec7 Mon Sep 17 00:00:00 2001
> +From: Awais Belal <awais_belal@mentor.com>
> +Date: Wed, 25 Oct 2017 21:00:05 +0500
> +Subject: [PATCH] dhcp: correct the intention for xml2 lib search
> +
> +A missing case breaks the build when libxml2 is
> +required and found appropriately. The third argument
> +to the function AC_SEARCH_LIB is action-if-found which
> +was mistakenly been used for the case where the library
> +is not found and hence breaks the configure phase
> +where it shoud actually pass.
> +We now pass on silently when action-if-found is
> +executed.
> +
> +Signed-off-by: Awais Belal <awais_belal@mentor.com>
> +---
> + configure.ac | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index bfe988a..f0459e6 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -608,7 +608,7 @@ AC_ARG_WITH(libxml2,
> + with_libxml2="$withval", with_libxml2="no")
> +
> + if test x$with_libxml2 != xno; then
> +- AC_SEARCH_LIBS(xmlTextWriterStartElement, [xml2],
> ++ AC_SEARCH_LIBS(xmlTextWriterStartElement, [xml2],,
> + [if test x$with_libxml2 != xauto; then
> + AC_MSG_FAILURE([*** Cannot find
> xmlTextWriterStartElement with -lxml2 and libxml2 was requested])
> + fi])
> +--
> +2.11.1
> +
> diff --git a/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
> b/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
> index 4634a01b04..6615ae2555 100644
> --- a/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
> +++ b/meta/recipes-connectivity/dhcp/dhcp_4.3.6.bb
> @@ -11,6 +11,7 @@ SRC_URI += "file://0001-define-macro-_
> PATH_DHCPD_CONF-and-_PATH_DHCLIENT_CON.pat
> file://0009-remove-dhclient-script-bash-dependency.patch \
> file://0010-build-shared-libs.patch \
> file://0011-Moved-the-call-to-isc_app_ctxstart-to-not-get-signal.patch
> \
> + file://0012-dhcp-correct-the-intention-for-xml2-lib-search.patch
> \
> "
>
> SRC_URI[md5sum] = "afa6e9b3eb7539ea048421a82c668adc"
> --
> 2.11.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 5832 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-07 14:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-25 16:03 [PATCH] dhcp: fix build issue with libxml2 support Awais Belal
2017-10-25 16:35 ` ✗ patchtest: failure for " Patchwork
2017-11-06 10:47 ` [PATCH] " Belal, Awais
2017-11-07 14:46 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox