Re: [PATCH] oeqa/selftest/runtime_test: fix postinst_rootfs_and_boot

[Patrick Ohly <patrick.ohly@intel.com>]

On Mon, 2017-11-06 at 17:55 +0000, Ross Burton wrote:
>                     testcommand = 'ls /etc/' + fileboot_name

Can't this be removed?

>                      with runqemu('core-image-minimal') as qemu:
> -                        ssh = SSHControl(ip=qemu.ip, logfile=qemu.sshlog)
> -                        status, output = ssh.run(testcommand)
> +                        status, output = qemu.run_serial("-f /etc/" + fileboot_name)

Did you mean "test -f"?

>                          self.assertEqual(status, 0, 'File %s was not created at first boot (%s)' % (fileboot_name, output))

run_serial has the quirk that status == 1 on *success*. Yes, weird.

The test probably passed because it was testing for failure, and the
missing "test" ensured that the command failed.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.