Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>,
	OpenEmbedded Core Mailing List
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image_types_wic.bbclass: Ensure '-c image_wic' works
Date: Tue, 19 Dec 2017 17:22:20 +0000	[thread overview]
Message-ID: <1513704140.16507.66.camel@linuxfoundation.org> (raw)
In-Reply-To: <20171219171706.396-1-otavio@ossystems.com.br>

On Tue, 2017-12-19 at 15:17 -0200, Otavio Salvador wrote:
> The 'wic' image may use files which has been deployed (e.g in
> do_deploy) for some partitions that may need to be copied in a
> specific partition or filesystem (e.g a bootloader).
> 
> When using 'bitbake <image> -c image_wic', from a clean build, the
> contents of do_deploy must also be available so we need to ensure all
> do_build of the image dependencies has been complete.
> 
> Reported-by: Fabio Berton <fabio.berton@ossystems.com.br>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
>  meta/classes/image_types_wic.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/classes/image_types_wic.bbclass
> b/meta/classes/image_types_wic.bbclass
> index 222ae00433..4d7305a3a3 100644
> --- a/meta/classes/image_types_wic.bbclass
> +++ b/meta/classes/image_types_wic.bbclass
> @@ -41,6 +41,9 @@ WKS_FILE_CHECKSUM = "${@'${WKS_FULL_PATH}:%s' %
> os.path.exists('${WKS_FULL_PATH}
>  do_image_wic[file-checksums] += "${WKS_FILE_CHECKSUM}"
>  do_image_wic[depends] += "${@' '.join('%s-
> native:do_populate_sysroot' % r for r in ('parted', 'gptfdisk',
> 'dosfstools', 'mtools'))}"
>  
> +# We ensure all artfacts are deployed (e.g virtual/bootloader)
> +do_image_wic[recrdeptask] += "do_build"

Shouldn't that be do_deploy instead of do_build?

Cheers,

Richard




  reply	other threads:[~2017-12-19 17:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19 17:17 [PATCH] image_types_wic.bbclass: Ensure '-c image_wic' works Otavio Salvador
2017-12-19 17:22 ` Richard Purdie [this message]
2017-12-19 17:38   ` Otavio Salvador
2017-12-19 18:07     ` Richard Purdie
2017-12-19 18:17       ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513704140.16507.66.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox