From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Joe Slater <jslater@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] allarch: do not set baselib
Date: Tue, 02 Jan 2018 22:45:38 +0000 [thread overview]
Message-ID: <1514933138.5525.101.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180102200049.44793-1-jslater@windriver.com>
On Tue, 2018-01-02 at 12:00 -0800, Joe Slater wrote:
> postinstall scripts may run target binaries and need to know
> where shared libraries are.
>
> Signed-off-by: Joe Slater <jslater@windriver.com>
> ---
> meta/classes/allarch.bbclass | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass
> index 51ba509..3749328 100644
> --- a/meta/classes/allarch.bbclass
> +++ b/meta/classes/allarch.bbclass
> @@ -11,9 +11,8 @@ python () {
> # No need for virtual/libc or a cross compiler
> d.setVar("INHIBIT_DEFAULT_DEPS","1")
>
> - # Set these to a common set of values, we shouldn't be using them other that for WORKDIR directory
> - # naming anyway
> - d.setVar("baselib", "lib")
> + # Set these to a common set of values, we shouldn't be using them other than for WORKDIR directory
> + # naming anyway. Do not set baselib because postinstall may need to know where shared libraries are.
> d.setVar("TARGET_ARCH", "allarch")
> d.setVar("TARGET_OS", "linux")
> d.setVar("TARGET_CC_ARCH", "none")
Sorry, but I don't think this can work :/.
Do the sstate sig selftests pass with this change?
I appreciate this will make some things "work" but it will mean that
allarch packages rebuild for each architecture or multilib and that
isn't right either.
So we need a better solution here. Why do we need libdir paths to run
binaries anyway? Is this a libexec issue? Perhaps the things in
question shouldn't be allarch?
Cheers,
Richard
next prev parent reply other threads:[~2018-01-02 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 20:00 [PATCH 1/1] allarch: do not set baselib Joe Slater
2018-01-02 22:45 ` Richard Purdie [this message]
2018-01-03 8:43 ` Alexander Kanavin
2018-01-03 21:46 ` Slater, Joseph
2018-01-03 21:58 ` Richard Purdie
2018-01-04 17:24 ` Slater, Joseph
2018-01-03 21:56 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1514933138.5525.101.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=jslater@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox