Re: [PATCH 1/1] testsdk: add ability to search for multilib packages

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2017-12-19 at 11:07 -0800, Joe Slater wrote:
> We search for packages related to the sdk environment
> being used for a test.

[...]
> @@ -33,6 +34,16 @@ class OESDKTestContext(OETestContextThreaded):
>      def hasTargetPackage(self, pkg):
>          return self._hasPackage(self.target_pkg_manifest, pkg)
>  
> +    def hasPrefixedTargetPackage(self, pkg):
> +        # extract multilib from environment script name
> +        try:
> +            p = re.match(".*(lib.?[36][24]-)linux-?",
> self.sdk_env).group(1) + pkg
> +        except:

I'm not sure this is correct, many of the prefixes are just "lib32-"
and there is no "linux" in there?

We could really use unit tests on these functions as we're heading into
unmaintainable spaghetti territory :(.

It may also be an option to iterate the configured multilibs and search
for each one, that way we avoid the regexp overhead?

Cheers,

Richard