Re: [PATCH] license.bbclass: set do_bootimg recrdeptask on do_populate_lic

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2018-02-15 at 15:11 +0100, Ming Liu wrote:
> I observed this issue on rocko branch, but I think upstream also
> needs it. Since even recrdepends handling had been changed in
> bitbake, the problem here is the "recrdepends" is missing between
> do_bootimg and do_populate_lic, actually there was a bug record for
> it, see: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9446, but
> the fix only considered the missing recrdepends of do_image, but
> looking into get_deployed_dependencies->get_boot_dependencies, the
> do_bootimg also needs a similar fix.

I've looked at this and this patch is not appropriate to be merged, its
a hack, piled on top of other hacks which still don't actually solve
the real problem.

do_bootimg is added before do_image_complete, after do_image, along
with a number of other image processing tasks. Either:

a) license.bbclass requires the do_image dependencies for license
processing.

b) license.bbclass requires the do_image_complete dependencies and
includes the tools used to produce the image.

There is no "in between" state. Creating some kind of mismash of
including some image tasks in the dependency list is simply not
appropriate, its defined as one or the other.

There is already "get_boot_dependencies" in license.bbclass which sets
of alarm bells. Your problem is clearly that you're not getting the
dependencies recursively.

Also, the license deploy manifest creation step is based on do_image
time, *not* do_image_complete. Its thereby defined as the manifest of
the things *in* the image, not the tools used to build the image.
Perhaps it should be at do_image_complete? If it were we might be able
to drop some of these other hacks too...

Cheers,

Richard