From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/3] liburcu: Explicitly add pthread options to cflags
Date: Fri, 09 Mar 2018 07:56:48 -0800 [thread overview]
Message-ID: <1520611008.10851.127.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180309110049.10725-2-raj.khem@gmail.com>
On Fri, 2018-03-09 at 03:00 -0800, Khem Raj wrote:
> Some architectures e.g. riscv gcc does not add -D_REENTRANT
> when enabling pthreads. Help it here by adding these options
> while gcc gets fixed
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-support/liburcu/liburcu_0.10.1.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> index 0c8cd3571a..a73890af90 100644
> --- a/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> +++ b/meta/recipes-support/liburcu/liburcu_0.10.1.bb
> @@ -15,3 +15,5 @@ SRC_URI[sha256sum] =
> "9c09220be4435dc27fcd22d291707b94b97f159e0c442fbcd60c168f8f
>
> S = "${WORKDIR}/userspace-rcu-${PV}"
> inherit autotools
> +
> +CPPFLAGS += "-pthread -D_REENTRANT"
Should we use a riscv override here so that we have some idea why we're
doing this and show its not needed for other arches?
Cheers,
Richard
next prev parent reply other threads:[~2018-03-09 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 11:00 [PATCH 1/3] packagegroup-core-sdk: Disable SANITIZERS for riscv64 Khem Raj
2018-03-09 11:00 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
2018-03-09 15:56 ` Richard Purdie [this message]
2018-03-09 16:24 ` Khem Raj
2018-03-09 11:00 ` [PATCH 3/3] recipes: Disable lttng for riscv Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2018-03-09 20:28 [PATCH 0/3] Build fixed for riscv64 Khem Raj
2018-03-09 20:29 ` [PATCH 2/3] liburcu: Explicitly add pthread options to cflags Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520611008.10851.127.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox