From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bhargava Sreekantappa Gayathri
<bhargava.sreekantappa-gayathri@xilinx.com>,
openembedded-core@lists.openembedded.org, manjukum@xilinx.com
Subject: Re: [PATCH] wget.py: handle BBFetchException
Date: Tue, 20 Mar 2018 23:07:37 +0000 [thread overview]
Message-ID: <1521587257.25754.206.camel@linuxfoundation.org> (raw)
In-Reply-To: <1521577519-32315-1-git-send-email-bhargava.sreekantappa-gayathri@xilinx.com>
On Tue, 2018-03-20 at 13:25 -0700, Bhargava Sreekantappa Gayathri
wrote:
> When BB_NO_NETWORK is set to 1 and the first mirror url needs network
> access, then bitbake will just fail and report error instead of going
> through the list of mirror urls. This is because BBFetchException is
> not
> handled when wget is called.
>
> This patch calls wget with a except blocks which returns to the
> previous
> function instead of failing immediately.
This doesn't look right to me unfortunately. It looks like you special
cased one fetcher module when mirrors using other fetchers could also
fail. I'd have expected a patch to fix this somewhere in the mirrors
code, not in individual fetchers.
Am I missing a bug in the wget fetcher?
Cheers,
Richard
prev parent reply other threads:[~2018-03-20 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 20:25 [PATCH] wget.py: handle BBFetchException Bhargava Sreekantappa Gayathri
2018-03-20 20:35 ` ✗ patchtest: failure for " Patchwork
2018-03-20 23:07 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521587257.25754.206.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bhargava.sreekantappa-gayathri@xilinx.com \
--cc=manjukum@xilinx.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox