Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [daisy][PATCH 2/6] kernel.bbclass: Remove bashism
Date: Tue, 20 Mar 2018 19:42:25 -0700	[thread overview]
Message-ID: <1521600149-3894-3-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1521600149-3894-1-git-send-email-armccurdy@gmail.com>

From: Khem Raj <raj.khem@gmail.com>

Fixes build on systems using dash for default shell e.g.

errors like

run.do_strip.25842: [[: not found
| readelf: Error: Unable to read in 0x37 bytes of section headers
| readelf: Error: Not an ELF file - it has the wrong magic bytes at the start

Change-Id: I29cac15be44a02d75a3d6889b6ae9b2e19bf46af
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
(cherry picked from commit 6956ffdc6e9879e32360b6ee3a3d286618807485)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 922752b..049f86b 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -391,7 +391,7 @@ python split_kernel_packages () {
 
 do_strip() {
 	if [ -n "${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}" ]; then
-		if [[ "${KERNEL_IMAGETYPE}" != "vmlinux" ]]; then
+		if [ "${KERNEL_IMAGETYPE}" != "vmlinux" ]; then
 			bbwarn "image type will not be stripped (not supported): ${KERNEL_IMAGETYPE}"
 			return
 		fi
-- 
1.9.1



  parent reply	other threads:[~2018-03-21  2:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21  2:42 [daisy][PATCH 0/6] SRC_URI updates and minor build fixes Andre McCurdy
2018-03-21  2:42 ` [daisy][PATCH 1/6] dtc: old SRC_URI died, changing to new working one Andre McCurdy
2018-03-21  2:42 ` Andre McCurdy [this message]
2018-03-21  2:42 ` [daisy][PATCH 3/6] gmp_4.2.1: fix build for MIPS Andre McCurdy
2018-03-21  2:42 ` [daisy][PATCH 4/6] ncurses: fix build with gcc 5 Andre McCurdy
2018-03-21  2:42 ` [daisy][PATCH 5/6] binutils: " Andre McCurdy
2018-03-21  2:42 ` [daisy][PATCH 6/6] mesa: fix SRC_URI Andre McCurdy
2018-05-08  1:22 ` [daisy][PATCH 0/6] SRC_URI updates and minor build fixes Andre McCurdy
2018-05-08  7:40   ` Richard Purdie
2018-05-08  9:06     ` Andre McCurdy
2018-05-08  9:15       ` Richard Purdie
2018-05-08 22:07         ` Andre McCurdy
2018-05-09 11:09           ` Richard Purdie
2018-05-10  4:36             ` Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521600149-3894-3-git-send-email-armccurdy@gmail.com \
    --to=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox