Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: improve reproducibility
Date: Tue, 03 Apr 2018 15:45:48 +0100	[thread overview]
Message-ID: <1522766748.11431.237.camel@linuxfoundation.org> (raw)
In-Reply-To: <CADkTA4MU2uOHG8L5SoiSOPrf-r25cnpLy+UTOR=VsDauSMz4eA@mail.gmail.com>

On Tue, 2018-04-03 at 10:11 -0400, Bruce Ashfield wrote:
> On Tue, Apr 3, 2018 at 9:59 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > On Tue, 2018-04-03 at 08:58 -0400, Bruce Ashfield wrote:
> > > 
> > > On Tue, Apr 3, 2018 at 12:23 AM, Jonathan Liu <net147@gmail.com>
> > > wrote:
> > > > 
> > > > 
> > > > Set KBUILD_BUILD_VERSION=1 to avoid build version being
> > > > incremented
> > > > on
> > > > every build. It is visible in the output of "cat /proc/version"
> > > > after
> > > > the hash character.
> > > It is possible that someone might actually want this feature, for
> > > debug or
> > > different build variants.
> > > 
> > > So this would be better as a variable that can be overridden.
> > Surely users can override it in this form (like the USER/HOST
> > variants
> > already there)?
> I've never used the user/host variant, so I don't know.
> 
> How can you override an exported variable in a shell function in a
> bbclass ? I've never tried.
> 
> I know for a fact, that I wouldn't want this on by default, hence my
> comment.

KBUILD_BUILD_VERSION[unexport] = "1"

will override the export flag...

Cheers,

Richard


  reply	other threads:[~2018-04-03 14:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03  4:23 [PATCH] kernel.bbclass: improve reproducibility Jonathan Liu
2018-04-03 12:58 ` Bruce Ashfield
2018-04-03 13:59   ` Richard Purdie
2018-04-03 14:11     ` Bruce Ashfield
2018-04-03 14:45       ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-05-18 21:05 Juro Bystricky
2017-05-18 21:10 ` Burton, Ross
2017-05-18 21:14   ` Bystricky, Juro
2017-05-20  4:49     ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522766748.11431.237.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox