Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andre McCurdy <armccurdy@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2 5/8] icu: move ASNEEDED over-ride into icu.inc
Date: Wed,  9 May 2018 14:46:45 -0700	[thread overview]
Message-ID: <1525902408-6796-5-git-send-email-armccurdy@gmail.com> (raw)
In-Reply-To: <1525902408-6796-1-git-send-email-armccurdy@gmail.com>

Move the recipe specific over-ride for ASNEEDED into the recipe to
make it more apparent that the over-ride is being applied (and that
it should be re-checked on version updates, etc).

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/conf/distro/include/as-needed.inc | 1 -
 meta/recipes-support/icu/icu.inc       | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/conf/distro/include/as-needed.inc b/meta/conf/distro/include/as-needed.inc
index 94f5b90..305e654 100644
--- a/meta/conf/distro/include/as-needed.inc
+++ b/meta/conf/distro/include/as-needed.inc
@@ -2,7 +2,6 @@
 ASNEEDED = "-Wl,--as-needed"
 
 ASNEEDED_pn-openobex = ""
-ASNEEDED_pn-icu = ""
 ASNEEDED_pn-pciutils = ""
 ASNEEDED_pn-puzzles = ""
 ASNEEDED_pn-rpm = ""
diff --git a/meta/recipes-support/icu/icu.inc b/meta/recipes-support/icu/icu.inc
index 983118c..f0786ba 100644
--- a/meta/recipes-support/icu/icu.inc
+++ b/meta/recipes-support/icu/icu.inc
@@ -31,6 +31,8 @@ EXTRA_OECONF_class-nativesdk = "--with-cross-build=${STAGING_ICU_DIR_NATIVE}"
 EXTRA_OECONF_append_class-target = "${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'be', ' --with-data-packaging=archive', '', d)}"
 TARGET_CXXFLAGS_append = "${@oe.utils.conditional('SITEINFO_ENDIANNESS', 'be', ' -DICU_DATA_DIR=\\""${datadir}/${BPN}/${PV}\\""', '', d)}"
 
+ASNEEDED = ""
+
 # strtod_l() is not supported by musl; also xlocale.h is missing
 # It is not possible to disable its use via configure switches or env vars
 # so monkey patching is needed.
-- 
1.9.1



  parent reply	other threads:[~2018-05-09 21:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 21:46 [PATCH v2 1/8] tune-corei7.inc: minor comment tweak to align with tune-core2.inc Andre McCurdy
2018-05-09 21:46 ` [PATCH v2 2/8] babeltrace: move ASNEEDED over-ride into the babeltrace recipe Andre McCurdy
2018-05-09 22:04   ` Khem Raj
2018-05-09 22:52     ` Andre McCurdy
2018-05-09 21:46 ` [PATCH v2 3/8] console-tools: move ASNEEDED over-ride into the console-tools recipe Andre McCurdy
2018-05-09 21:46 ` [PATCH v2 4/8] distcc: move ASNEEDED over-ride into the distcc recipe Andre McCurdy
2018-05-09 21:46 ` Andre McCurdy [this message]
2018-05-09 21:46 ` [PATCH v2 6/8] pciutils: move ASNEEDED over-ride into the pciutils recipe Andre McCurdy
2018-05-09 21:46 ` [PATCH v2 7/8] puzzles: move ASNEEDED over-ride into the puzzles recipe Andre McCurdy
2018-05-09 21:46 ` [PATCH v2 8/8] rpm: move ASNEEDED over-ride into the rpm recipe Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525902408-6796-5-git-send-email-armccurdy@gmail.com \
    --to=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox