Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Andre McCurdy <armccurdy@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bitbake.conf: drop obsolete comment referring to the fail-fast over-ride
Date: Mon, 14 May 2018 23:23:26 +0100	[thread overview]
Message-ID: <1526336606.5720.145.camel@linuxfoundation.org> (raw)
In-Reply-To: <1526332154-20637-1-git-send-email-armccurdy@gmail.com>

On Mon, 2018-05-14 at 14:09 -0700, Andre McCurdy wrote:
> The comment appears to have been accidentally left behind when the
> fail-fast over-ride was removed by:
> 
>   http://git.openembedded.org/openembedded-core/commit/?id=83ce96f445
> 16c8a4a44c8c0140949256f8422014
> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/conf/bitbake.conf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a21b728..a74d8cf 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -733,8 +733,8 @@ DISTRO_NAME ??= "OpenEmbedded"
>  # '_qemuarm' and then '' will be overriden with that value from '_qemuarm'.
>  # And finally '_forcevariable' overrides any standard variable, with the highest priority.
>  #
> -# This works for  functions as well, they are really just environment variables.
> -# Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
> +# This works for functions as well, they are really just environment variables.

If we're going to fix the comment, could you remove the word
"environment" from there too please? :)

Cheers,

Richard


      reply	other threads:[~2018-05-14 22:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 21:09 [PATCH] bitbake.conf: drop obsolete comment referring to the fail-fast over-ride Andre McCurdy
2018-05-14 22:23 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526336606.5720.145.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox