From: Ryan Harkin <ryan.harkin@linaro.org>
To: openembedded-core@lists.openembedded.org
Cc: daiane.angolini@nxp.com, patches@linaro.org
Subject: [RFC 0/3] Adding BCM43430 NVRAM files
Date: Wed, 22 Aug 2018 17:30:33 +0100 [thread overview]
Message-ID: <1534955436-729-1-git-send-email-ryan.harkin@linaro.org> (raw)
[Resending because I sent to the wrong email address for the oe-core
mailing list]
NVRAM files for the 43430 modules have been committed into the upstream
Linux firmware repo. I'd like to add these files into the linux-firmware
recipe.
The following files exist upstream on kernel.org:
- brcm/brcmfmac43430-sdio.AP6212.txt
- brcm/brcmfmac43430-sdio.MUR1DX.txt
The AP6212 and MUR1DX are the module types for variants of the 43430
chips.
The first patch is a simple update to the latest upstream. I guess
someone else will commit a similar change before I get to it, but for
now, I need to make the update to test my changes, so I thought I'd send
the patch with my RFC series.
The second patch adds both NVRAM files into a single new variable.
Ideally, the Linux kernel will be extended detect the module type, so
having all the NVRAM files in /lib/firmware/brcm seems like a sensible
thing to do. But advice here is appreciated. Perhaps I should have a
separate variable for each file and allow the machine config to choose
which configs to include in the filesystem, similar to how the .bin
files are included since Martin Jansa's change?
The 3rd patch is trickier, I think. At the moment, the Linux kernel
expects there to be only one NVRAM file, named brcmfmac43430-sdio.txt.
So to make the system "just work", it seems sensible to provide a way to
softlink the module specific NVRAM to the generic filename.
I'm trying to avoid each machine type having to define a softlink
_append in its own config. Many different machines can use the same
module type, for example. I'm just not convinced that the way I've done
it is appropriate. eg. I don't like the usage of MACHINEOVERRIDE, or the
variable name I've chosen. I'd hoped to do it using a
MACHINE_EXTRA_RRECOMMENDS, but I'm not sure if that is possible. Again,
advice is appreciated.
Ryan Harkin (3):
linux-firmware: upgrade to 1d17c18 revision
linux-firmware: add BCM43430 nvram files
linux-firmware: MACHINEOVERRIDES for BCM43430 NVRAM
.../linux-firmware/linux-firmware_git.bb | 23 +++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
--
2.7.4
next reply other threads:[~2018-08-22 16:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 16:30 Ryan Harkin [this message]
2018-08-22 16:30 ` [RFC 1/3] linux-firmware: upgrade to 1d17c18 revision Ryan Harkin
2018-08-22 16:30 ` [RFC 2/3] linux-firmware: add BCM43430 nvram files Ryan Harkin
2018-08-22 16:30 ` [RFC 3/3] linux-firmware: MACHINEOVERRIDES for BCM43430 NVRAM Ryan Harkin
2018-08-22 16:41 ` Martin Jansa
2018-08-22 16:47 ` Ryan Harkin
2018-08-22 16:56 ` Martin Jansa
2018-08-22 17:11 ` Ryan Harkin
2018-08-22 19:02 ` Martin Jansa
2018-08-22 20:10 ` Ryan Harkin
2018-08-22 20:36 ` Khem Raj
2018-08-22 21:52 ` Ryan Harkin
2018-08-22 20:42 ` Andre McCurdy
2018-08-22 21:56 ` Ryan Harkin
2018-08-22 22:55 ` Andre McCurdy
2018-08-23 6:12 ` Ryan Harkin
2018-08-23 6:39 ` Martin Hundebøll
2018-08-23 7:08 ` Ryan Harkin
2018-08-23 7:19 ` Andre McCurdy
2018-08-23 15:58 ` Khem Raj
2018-08-23 7:06 ` Andre McCurdy
2018-08-23 7:17 ` Ryan Harkin
2018-08-23 7:34 ` Andre McCurdy
2018-08-23 7:36 ` Ryan Harkin
2018-08-23 8:15 ` Ryan Harkin
2018-08-24 2:53 ` Andre McCurdy
2018-08-24 9:04 ` Martin Jansa
2018-08-24 10:43 ` Mike Looijmans
2018-08-28 10:54 ` Ryan Harkin
2018-08-24 10:50 ` Ryan Harkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534955436-729-1-git-send-email-ryan.harkin@linaro.org \
--to=ryan.harkin@linaro.org \
--cc=daiane.angolini@nxp.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox