From: Andrew Geissler <geissonator@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Andrew Geissler <geissonator@gmail.com>,
alejandro.enedino.hernandez-samaniego@xilinx.com
Subject: [PATCH 2/3] python: respect package order in manifest
Date: Fri, 14 Sep 2018 14:33:07 -0700 [thread overview]
Message-ID: <1536960788-26056-2-git-send-email-geissonator@gmail.com> (raw)
In-Reply-To: <1536960788-26056-1-git-send-email-geissonator@gmail.com>
Don't sort the manifest when using it to generate packaging rules, so
ordering can be used to have complex packaging rules.
This is a backport of the same changes done by Ross Burton for python3
Signed-off-by: Andrew Geissler <geissonator@gmail.com>
---
meta/recipes-devtools/python/python_2.7.15.bb | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
index 43d9ff5..472c1da 100644
--- a/meta/recipes-devtools/python/python_2.7.15.bb
+++ b/meta/recipes-devtools/python/python_2.7.15.bb
@@ -207,7 +207,7 @@ RPROVIDES_${PN} += "${PN}-modules"
INCLUDE_PYCS ?= "1"
python(){
- import json
+ import collections, json
filename = os.path.join(d.getVar('THISDIR'), 'python', 'python2-manifest.json')
# This python changes the datastore based on the contents of a file, so mark
@@ -215,7 +215,7 @@ python(){
bb.parse.mark_dependency(d, filename)
with open(filename) as manifest_file:
- python_manifest=json.load(manifest_file)
+ python_manifest=json.load(manifest_file, object_pairs_hook=collections.OrderedDict)
include_pycs = d.getVar('INCLUDE_PYCS')
@@ -248,8 +248,6 @@ python(){
d.appendVar('RDEPENDS_' + pypackage, ' ' + pn + '-' + value)
d.setVar('SUMMARY_' + pypackage, python_manifest[key]['summary'])
- # We need to ensure staticdev packages match for files first so we sort in reverse
- newpackages.sort(reverse=True)
# Prepending so to avoid python-misc getting everything
packages = newpackages + packages
d.setVar('PACKAGES', ' '.join(packages))
--
2.7.4
next prev parent reply other threads:[~2018-09-14 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 21:33 [PATCH 1/3] python: don't sort the manifest in create_manifest Andrew Geissler
2018-09-14 21:33 ` Andrew Geissler [this message]
2018-09-19 11:08 ` [PATCH 2/3] python: respect package order in manifest Burton, Ross
2018-09-19 13:13 ` Andrew Geissler
2018-09-14 21:33 ` [PATCH 3/3] python: consolidate tests Andrew Geissler
2018-09-19 13:25 ` [PATCH 1/3] python: don't sort the manifest in create_manifest Andrew Geissler
2018-09-19 13:37 ` ✗ patchtest: failure for "python: don't sort the manifes..." and 2 more (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536960788-26056-2-git-send-email-geissonator@gmail.com \
--to=geissonator@gmail.com \
--cc=alejandro.enedino.hernandez-samaniego@xilinx.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox