From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by mail.openembedded.org (Postfix) with ESMTP id A729A74A35 for ; Tue, 4 Sep 2018 02:12:59 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id w842Cw8S008405 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 3 Sep 2018 19:12:58 -0700 Received: from [128.224.162.214] (128.224.162.214) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.408.0; Mon, 3 Sep 2018 19:12:57 -0700 Reply-To: To: Tim Orling , Tom Rini References: <1535681710-29461-1-git-send-email-lu.jiang@windriver.com> <1535681710-29461-3-git-send-email-lu.jiang@windriver.com> <20180831135324.GO26633@bill-the-cat> <20180903025056.GE26633@bill-the-cat> From: "Lu.Jiang" Message-ID: <1551786b-ce15-921c-2a87-ecb6c9ae581a@windriver.com> Date: Tue, 4 Sep 2018 10:10:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [128.224.162.214] Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 2/7] wic:move wic src into meta/receipt-support/wic X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 02:12:59 -0000 Content-Type: multipart/alternative; boundary="------------6BE1B5D8011C052F3DBE4492" Content-Language: en-US --------------6BE1B5D8011C052F3DBE4492 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit The patch move source code for wic from lib/script into meta/receipt-support/wic. Then wic compiled as an individual package. When building wic image on host, imagetype-wic.bbclass invoke wic-native. This is almost same as before. After applied those patch, wic also run on target, allow user create wic image on target board based on supplied components image or based on a running system. BTW, I checked code moved in this patch, didn't found reference path in code. Thanks Jiang Lu 在 2018年09月03日 23:14, Tim Orling 写道: > Also, what is the reason for the move? What problem does it solve? Why > is it better to move it? > On Sun, Sep 2, 2018 at 7:51 PM Tom Rini > wrote: > > On Mon, Sep 03, 2018 at 09:58:01AM +0800, Lu.Jiang wrote: > > > This patch simply move code from script/lib/wic into > > meta/recipes-support/wic/files. I didn't touch code in this patch. > > > > Please see attachment for patch formatted with -M. > > Exactly, formatted with -M it's clear and a short patch.  A follow-up > question now, are there any comment paths, etc, that should be changed > as part of the move? > > -- > Tom > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > --------------6BE1B5D8011C052F3DBE4492 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
The patch move source code for wic from lib/script into meta/receipt-support/wic. Then wic compiled as an individual package.

When building wic image on host, imagetype-wic.bbclass invoke wic-native. This is almost same as before.

After applied those patch, wic also run on target, allow user create wic image on target board based on supplied components image or based on a running system.

BTW, I checked code moved in this patch, didn't found reference path in code.

Thanks
Jiang Lu

在 2018年09月03日 23:14, Tim Orling 写道:
Also, what is the reason for the move? What problem does it solve? Why is it better to move it?
On Sun, Sep 2, 2018 at 7:51 PM Tom Rini <trini@konsulko.com> wrote:
On Mon, Sep 03, 2018 at 09:58:01AM +0800, Lu.Jiang wrote:

> This patch simply move code from script/lib/wic into
> meta/recipes-support/wic/files. I didn't touch code in this patch.
>
> Please see attachment for patch formatted with -M.

Exactly, formatted with -M it's clear and a short patch.  A follow-up
question now, are there any comment paths, etc, that should be changed
as part of the move?

--
Tom
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


--------------6BE1B5D8011C052F3DBE4492--