Re: [PATCH] gdb: add PACKAGECONFIG for xz (lzma) compression support

Richard Purdie
2020-01-21T00:04:56Z

On Tue, 2020-01-21 at 09:48 +1000, Dan Callaghan wrote:
> Similar to elfutils, when xz support is built into gdb it will be able
> to read xz-compressed ELF sections containing debuginfo. This is used by
> the "mini debuginfo" format:
>
> https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
> ---
> meta/recipes-devtools/gdb/gdb-common.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index 08f615addf..5d670561b0 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -21,7 +21,7 @@ EXPAT = "--with-expat --with-libexpat-prefix=${STAGING_DIR_HOST}"
>
> EXTRA_OECONF = "--disable-gdbtk --disable-x --disable-werror \
> --with-curses --disable-multilib --disable-sim \
> - --without-lzma --without-guile \
> + --without-guile \
> ${GDBPROPREFIX} ${EXPAT} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
> --disable-rpath \
> @@ -37,6 +37,7 @@ PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,python
> PACKAGECONFIG[babeltrace] = "--with-babeltrace,--without-babeltrace,babeltrace"
> # ncurses is already a hard DEPENDS, but would be added here if it weren't
> PACKAGECONFIG[tui] = "--enable-tui,--disable-tui"
> +PACKAGECONFIG[xz] = "--with-lzma,--without-lzma"
>
> GDBPROPREFIX = "--program-prefix=''"

Is there an extra DEPENDS needed when enabling this?

Cheers,

Richard