From: "Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)" <dzagorui@cisco.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] kernel-devsrc: improve reproducibility for arm64
Date: Fri, 30 Oct 2020 12:30:30 +0000 [thread overview]
Message-ID: <1604061028970.9082@cisco.com> (raw)
In-Reply-To: <CADkTA4OGBOtnMD=t1xppe-5quLow8uPf99ZHknrSnPLAQKkoDA@mail.gmail.com>
> > .vdso-offsets.h.cmd contains command that was used to produce vdso-offsets.h.
> > It breaks reproducibility because it has an absolute path in it. There is no
> > any value to package such files so it can be dropped.
> >
>
> Have you confirmed that an on-target 'make scripts prepare' property
> regenerates the file without triggering and oldconfig ?
>
> Otherwise, the change looks fine to me.
>
> Bruce
Yes, confirmed that oldconfig wont be triggered.
Thanks,
Denys
>
> > Signed-off-by: Denys Zagorui <dzagorui@cisco.com>
> > ---
> > meta/recipes-kernel/linux/kernel-devsrc.bb | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > index aa8e162f4f..f8c750beaa 100644
> > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > @@ -113,6 +113,10 @@ do_install() {
> > # but without this file, we get a forced syncconfig run in v5.8+, which prompts and
> > # breaks workflows.
> > cp -a --parents include/generated/autoconf.h $kerneldir/build 2>/dev/null || :
> > +
> > + if [ -e $kerneldir/include/generated/.vdso-offsets.h.cmd ]; then
> > + rm $kerneldir/include/generated/.vdso-offsets.h.cmd
> > + fi
> > )
> >
> > # now grab the chunks from the source tree that we need
> > --
> > 2.19.0.dirty
> >
> >
> >
> >
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
next prev parent reply other threads:[~2020-10-30 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 11:40 [PATCH] kernel-devsrc: improve reproducibility for arm64 Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
2020-10-29 11:44 ` [OE-core] " Bruce Ashfield
2020-10-30 12:30 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco) [this message]
[not found] ` <1642C502B17F26A6.28917@lists.openembedded.org>
2020-11-09 9:53 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
[not found] ` <1645CE4049F0E4CD.31324@lists.openembedded.org>
2020-11-16 15:14 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
2020-11-16 15:23 ` Bruce Ashfield
2020-11-16 15:29 ` Denys Zagorui -X (dzagorui - GLOBALLOGIC INC@Cisco)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604061028970.9082@cisco.com \
--to=dzagorui@cisco.com \
--cc=bruce.ashfield@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox