Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "hongxu" <hongxu.jia@eng.windriver.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] classes/spdx-common: Fix patch error for recipes that inherit dos2unix.
Date: Thu, 23 Jan 2025 00:03:31 -0800	[thread overview]
Message-ID: <16166.1737619411751493273@lists.openembedded.org> (raw)
In-Reply-To: <9c98a7d0304062e884e35823af9a97f30bff75b3.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi RP,

Convert do_convert_crlf_to_lf from a separate task to a postfunc or prefunc
is not suitable for this case, the postfunc and prefunc is executed in
bb.build.exec_task [1], but do_patch is called by bb.build.exec_func
in archiver.bbclass and meta/lib/oe/spdx_common.py
Which means postfunc or prefunc will not be invoked in bb.build.exec_func

I think prepend function to task do_patch could workaround the issue, v2 incoming

[1] https://git.yoctoproject.org/poky/commit/?id=0f516fe9a043276c670622895c4760ff6468f293

//Hongxu

[-- Attachment #2: Type: text/html, Size: 838 bytes --]

  reply	other threads:[~2025-01-23  8:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22  4:42 [PATCH] classes/spdx-common: Fix patch error for recipes that inherit dos2unix Hongxu Jia
2025-01-22 13:26 ` [OE-core] " Richard Purdie
2025-01-23  8:03   ` hongxu [this message]
2025-01-23  8:18     ` Richard Purdie
     [not found]     ` <181D447E5FAF7FB4.25327@lists.openembedded.org>
2025-01-23  8:38       ` Richard Purdie
2025-01-23  8:56         ` hongxu
2025-01-23  8:25 ` [PATCH v2] dos2unix.bbclass: " Hongxu Jia
2025-01-23  8:38   ` [OE-core] " Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16166.1737619411751493273@lists.openembedded.org \
    --to=hongxu.jia@eng.windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox