From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: bjorn.arnelid@xdin.com
Subject: Re: [PATCH] qemu.inc: Fix typo for KERNEL_FEATURES
Date: Fri, 13 Sep 2013 10:19:51 +0100 [thread overview]
Message-ID: <1628869.GrtJx7trgC@helios> (raw)
In-Reply-To: <20130913084724.GC11500@jama>
On Friday 13 September 2013 10:47:24 Martin Jansa wrote:
> On Thu, Sep 12, 2013 at 11:42:54PM -0700, Saul Wold wrote:
> > Thans to Bjorn Arnelid for finding this
> >
> > Cc: bjorn.arnelid@xdin.com
> >
> > [YOCTO #5173]
> >
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >
> > meta/conf/machine/include/qemu.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/machine/include/qemu.inc
> > b/meta/conf/machine/include/qemu.inc index a78622d..8557777 100644
> > --- a/meta/conf/machine/include/qemu.inc
> > +++ b/meta/conf/machine/include/qemu.inc
> > @@ -26,4 +26,4 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
> >
> > EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
> >
> > # Provide the nfs server kernel module for all qemu images
> >
> > -KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
> > +KERNEL_FEATURES_append_pn_linux-yocto = " features/nfsd/nfsd-enable.scc"
>
> Wait a minute, isn't _pn-foo correct override?
It is. Bjorn and I discussed this on IRC already, this patch shouldn't be
applied. He's switched back to the linux-yocto 3.2 kernel and I guess that
feature is not available/working there, thus this change did fix his build
failure as it effectively disabled the line. Perhaps we should fix the
underlying bug instead? Bruce, any suggestions?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-09-13 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 6:42 [PATCH] qemu.inc: Fix typo for KERNEL_FEATURES Saul Wold
2013-09-13 8:47 ` Martin Jansa
2013-09-13 9:19 ` Paul Eggleton [this message]
2013-09-13 13:49 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628869.GrtJx7trgC@helios \
--to=paul.eggleton@linux.intel.com \
--cc=bjorn.arnelid@xdin.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox