From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [RFC v2][PATCH 1/3] buildhistory: record all builds
Date: Tue, 20 Mar 2012 13:51:57 +0000 [thread overview]
Message-ID: <16657624.ejDoFzWrx1@helios> (raw)
In-Reply-To: <1332250734-14660-1-git-send-email-koen@dominion.thruhere.net>
On Tuesday 20 March 2012 14:38:52 Koen Kooi wrote:
> Allow empty commits, this also give a nice speedup since 'git status
> --porcelain' doesn't need to get run.
I guess my thinking before (without any verification) was that git commit would
need to be running the equivalent of 'git status --porcelain' anyway and the
second time it would be cached so there wouldn't be much impact. If the
buildhistory repo is quite large or the machine is busy then it's entirely
possible that wouldn't work out however.
Since all image builds will force a commit anyway (as at least build-id must
change), and for the majority of people most builds will be image builds, I
think this is going to be a net improvement.
Therefore I'll say:
Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-20 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 13:38 [RFC v2][PATCH 1/3] buildhistory: record all builds Koen Kooi
2012-03-20 13:38 ` [RFC v2][PATCH 2/3] buildhistory: make seperate commits for every entry in the buildhistory dir Koen Kooi
2012-03-20 13:38 ` [RFC v2][PATCH 3/3] buildhistory: remove duplicate entries from dot graph Koen Kooi
2012-03-20 13:51 ` Paul Eggleton [this message]
2012-03-20 14:08 ` [RFC v2][PATCH 1/3] buildhistory: record all builds Koen Kooi
2012-03-22 10:35 ` Koen Kooi
2012-03-22 14:25 ` Paul Eggleton
2012-03-22 14:33 ` Martin Jansa
2012-03-22 14:46 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16657624.ejDoFzWrx1@helios \
--to=paul.eggleton@linux.intel.com \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox