Re: [PATCH] qt4-x11-free: disable QGtkStyle

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Friday 20 September 2013 15:58:26 Andreas Müller wrote:
> On Fri, Sep 20, 2013 at 3:01 PM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
> > This currently leads to a floating dependency on GTK+. Since most users
> > in an embedded context won't need this, just disable it by default.
> > 
> > Fixes [YOCTO #5116].
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> > 
> >  meta/recipes-qt/qt4/qt4-x11-free.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-qt/qt4/qt4-x11-free.inc
> > b/meta/recipes-qt/qt4/qt4-x11-free.inc index 4b29f55..369b3d5 100644
> > --- a/meta/recipes-qt/qt4/qt4-x11-free.inc
> > +++ b/meta/recipes-qt/qt4/qt4-x11-free.inc
> > @@ -12,7 +12,7 @@ INC_PR = "r50"
> > 
> >  QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl',
> >  '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl"
> >  QT_GLFLAGS_qemuppc = "-opengl"
> > 
> > -QT_X11_FLAGS ?= "-no-xinerama -no-xkb"
> > +QT_X11_FLAGS ?= "-no-xinerama -no-xkb -no-gtkstyle"
> > 
> >  QT_CONFIG_FLAGS += "${QT_X11_FLAGS}"
> >  QT_BASE_LIB  ?= "libqt"
>
> How about PACKAGECONFIG for this?

Ultimately I decided against introducing PACKAGECONFIG just for this, because 
the Qt recipes currently avoid it (PACKAGECONFIG cannot support a number of 
the additional library options for Qt since they are tri-state; not to mention 
that PACKAGECONFIG isn't just a drop-in for Qt because it doesn't use 
autotools/cmake and therefore doesn't use EXTRA_OECONF/EXTRA_OECMAKE). I 
figured that the few users who do want QGTKStyle can just set QT_X11_FLAGS as 
desired.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre