On Thu, Oct 20, 2022 at 06:17 AM, Joshua Watt wrote:<br />
<blockquote>On Wed, Oct 19, 2022 at 6:08 AM Keiya Nobuta &lt;nobuta.keiya@fujitsu.com&gt; wrote:<br />
<blockquote>Fixed an issue that "licenseDeclared" shows weird value, for example<br />`busybox.spdx.json` shows like:<br /><br />"GPL-2.0-only AND DocumentRef-recipe-busybox:LicenseRef-bzip2-1.0.4"<br />^^^^^^^^^^^^^^^^^^^^^^^^^^^<br />unwanted value</blockquote>
I don't believe this is unwanted: the license text lives in another<br />document (ecipe-busybox.spdx.json) so we need to indicate that here</blockquote>
<div>Thanks for your comment.</div>
<div>I was misunderstanding, so I'm withdrawing this patch.</div>
<div>&nbsp;</div>
<div>&nbsp;</div>
<div>The reason I got it wrong was because the SPDX validation tool[1]<br />gave me the following message:</div>
<div>&nbsp;</div>
<div>```</div>
<div>The following warning(s) were raised: [Invalid package</div>
<div>declared license:Incompatible type for property member: class</div>
<div>org.spdx.library.model.license.AnyLicenseInfo]</div>
<div>```</div>
<div>&nbsp;</div>
<div>
<div>But this is probably due to a flaw in the validation tool. So I checked the</div>
<div>SPDX specification[2], and understood that it complies with the user defined</div>
<div>license reference.</div>
</div>
<div>&nbsp;</div>
<div>[1] https://tools.spdx.org/app/validate/</div>
<div>[2] https://spdx.github.io/spdx-spec/SPDX-license-expressions/</div>
<div>&nbsp;</div>
<br />
<blockquote>
<blockquote>Signed-off-by: Keiya Nobuta &lt;nobuta.keiya@fujitsu.com&gt;<br />---<br />meta/classes/create-spdx.bbclass | 2 +-<br />1 file changed, 1 insertion(+), 1 deletion(-)<br /><br />diff --git a/meta/classes/create-spdx.bbclass b/meta/classes/create-spdx.bbclass<br />index c190ad3889..1661c7d2f0 100644<br />--- a/meta/classes/create-spdx.bbclass<br />+++ b/meta/classes/create-spdx.bbclass<br />@@ -534,7 +534,7 @@ python do_create_spdx() {<br />recipe_ref.checksum.checksumValue = doc_sha1<br /><br />sources = collect_dep_sources(d, dep_recipes)<br />- found_licenses = {license.name:recipe_ref.externalDocumentId + ":" + license.licenseId for license in doc.hasExtractedLicensingInfos}<br />+ found_licenses = {license.name: license.licenseId for license in doc.hasExtractedLicensingInfos}<br /><br />if not recipe_spdx_is_native(d, recipe):<br />bb.build.exec_func("read_subpackage_metadata", d)<br />--<br />2.25.1<br /><br /><br /></blockquote>
</blockquote>