Re: [OE-core] [PATCH 19/24] python3-setuptools: upgrade 72.1.0 -> 72.2.0

Martin Jansa
2024-09-05T12:44:47Z

Hi Khem,

it's surely related, but not a simple revert (as distutils commits are
merged into setuptools into different prefix and there were couple
commits on top), but with most of it reverted as in:
https://git.openembedded.org/openembedded-core-contrib/commit/?h=jansa/master-setuptools&id=cf310822e986802b0b97a7dcac2b9022d640efab
it no longer fails (tested with python3-icu with ccache enabled).

Regards,

On Tue, Sep 3, 2024 at 7:01 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> Hi Martin
>
> Can you try reverting this patch
>
> https://github.com/pypa/setuptools/commit/2c937116cc0dcd9b26b6070e89a3dc5dcbedc2ae
>
> and see if it helps ?
>
> On Tue, Sep 3, 2024 at 1:36 AM Martin Jansa via lists.openembedded.org
> <martin.jansa=gmail.com@lists.openembedded.org> wrote:
> >
> > Hello Wang,
> >
> > did you have a look at this regression (with ccache) from the
> > setuptools upgrade?
> >
> > Regards,
> >
> > On Thu, Aug 22, 2024 at 6:30 PM Martin Jansa <martin.jansa@gmail.com> wrote:
> > >
> > > This seems to break python3-numpy build.
> > >
> > > I guess it can be resolved by upgrading numpy as in:
> > > https://lists.openembedded.org/g/openembedded-core/message/203231
> > > which switches from setuptools3 to python_mesonpy
> > >
> > > Comparing the failing command line it looks like CXX and some other
> > > flags are included twice:
> > >
> > > with: setuptools-72.2.0:
> > >
> > > ccache \
> > > aarch64-oe-linux-g++ \
> > > -fstack-protector-all \
> > > -O2 \
> > > -D_FORTIFY_SOURCE=2 \
> > > -Wformat \
> > > -Wformat-security \
> > > -Werror=format-security \
> > > -Werror=return-type \
> > > -funwind-tables \
> > > --sysroot=WORKDIR/recipe-sysroot \
> > > -O2 \
> > > -g \
> > > -fcanon-prefix-map \
> > > -fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fmacro-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot-native= \
> > > -pipe \
> > > -fvisibility-inlines-hidden \
> > > aarch64-oe-linux-g++ \
> > > -fstack-protector-all \
> > > -O2 \
> > > -D_FORTIFY_SOURCE=2 \
> > > -Wformat \
> > > -Wformat-security \
> > > -Werror=format-security \
> > > -Werror=return-type \
> > > -funwind-tables \
> > > --sysroot=WORKDIR/recipe-sysroot \
> > > -shared \
> > > -Wl,-O1 \
> > > -Wl,--hash-style=gnu \
> > > -Wl,--as-needed \
> > > -fcanon-prefix-map \
> > > -fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fmacro-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot-native= \
> > > -Wl,-z,relro,-z,now \
> > > -O2 \
> > > -g \
> > > -fcanon-prefix-map \
> > > -fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fmacro-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot-native= \
> > > -pipe \
> > > -fvisibility-inlines-hidden \
> > > build/temp.linux-x86_64-cpython-312/build/src.linux-x86_64-3.12/numpy/core/src/multiarray/_multiarray_tests.o
> > > \
> > > build/temp.linux-x86_64-cpython-312/numpy/core/src/common/mem_overlap.o \
> > > build/temp.linux-x86_64-cpython-312/numpy/core/src/common/npy_argparse.o \
> > > build/temp.linux-x86_64-cpython-312/numpy/core/src/common/npy_hashtable.o \
> > > -LWORKDIR/recipe-sysroot/usr/lib \
> > > -Lbuild/temp.linux-x86_64-cpython-312 \
> > > -lnpymath \
> > > -o \
> > > build/lib.linux-x86_64-cpython-312/numpy/core/_multiarray_tests.cpython-312-aarch64-linux-gnu.so
> > >
> > > --- setuptools-72.1.0 2024-08-22 18:17:36.941146726 +0200
> > > +++ setuptools-72.2.0 2024-08-22 18:17:27.208147768 +0200
> > > @@ -9,6 +9,28 @@
> > > -Werror=return-type \
> > > -funwind-tables \
> > > --sysroot=WORKDIR/recipe-sysroot \
> > > +-O2 \
> > > +-g \
> > > +-fcanon-prefix-map \
> > > +-fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > +-fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > +-fmacro-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > +-fdebug-prefix-map=WORKDIR/numpy-1.26.4=/usr/src/debug/python3-numpy/1.26.4 \
> > > +-fdebug-prefix-map=WORKDIR/recipe-sysroot= \
> > > +-fmacro-prefix-map=WORKDIR/recipe-sysroot= \
> > > +-fdebug-prefix-map=WORKDIR/recipe-sysroot-native= \
> > > +-pipe \
> > > +-fvisibility-inlines-hidden \
> > > +aarch64-oe-linux-g++ \
> > > +-fstack-protector-all \
> > > +-O2 \
> > > +-D_FORTIFY_SOURCE=2 \
> > > +-Wformat \
> > > +-Wformat-security \
> > > +-Werror=format-security \
> > > +-Werror=return-type \
> > > +-funwind-tables \
> > > +--sysroot=WORKDIR/recipe-sysroot \
> > > -shared \
> > > -Wl,-O1 \
> > > -Wl,--hash-style=gnu \
> > > @@ -33,6 +55,7 @@
> > > -fmacro-prefix-map=WORKDIR/recipe-sysroot= \
> > > -fdebug-prefix-map=WORKDIR/recipe-sysroot-native= \
> > > -pipe \
> > > +-fvisibility-inlines-hidden \
> > > build/temp.linux-x86_64-cpython-312/build/src.linux-x86_64-3.12/numpy/core/src/multiarray/_multiarray_tests.o
> > > \
> > > build/temp.linux-x86_64-cpython-312/numpy/core/src/common/mem_overlap.o \
> > > build/temp.linux-x86_64-cpython-312/numpy/core/src/common/npy_argparse.o \
> > >
> > > failing with:
> > > WORKDIR/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/14.2.0/ld:
> > > cannot find aarch64-oe-linux-g++: No such file or directory
> > > collect2: error: ld returned 1 exit status
> > >
> > > On Tue, Aug 20, 2024 at 8:52 AM wangmy via lists.openembedded.org
> > > <wangmy=fujitsu.com@lists.openembedded.org> wrote:
> > > >
> > > > From: Wang Mingyu <wangmy@fujitsu.com>
> > > >
> > > > Changelog:
> > > > - Support for Pathlike objects in data files and extensions
> > > > - native support for C++ compilers
> > > > - removed unused get_msvcr()
> > > >
> > > > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > > > ---
> > > > ...ython3-setuptools_72.1.0.bb => python3-setuptools_72.2.0.bb} | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > rename meta/recipes-devtools/python/{python3-setuptools_72.1.0.bb => python3-setuptools_72.2.0.bb} (94%)
> > > >
> > > > diff --git a/meta/recipes-devtools/python/python3-setuptools_72.1.0.bb b/meta/recipes-devtools/python/python3-setuptools_72.2.0.bb
> > > > similarity index 94%
> > > > rename from meta/recipes-devtools/python/python3-setuptools_72.1.0.bb
> > > > rename to meta/recipes-devtools/python/python3-setuptools_72.2.0.bb
> > > > index 945d443aff..63ea999960 100644
> > > > --- a/meta/recipes-devtools/python/python3-setuptools_72.1.0.bb
> > > > +++ b/meta/recipes-devtools/python/python3-setuptools_72.2.0.bb
> > > > @@ -11,7 +11,7 @@ SRC_URI:append:class-native = " file://0001-conditionally-do-not-fetch-code-by-e
> > > > SRC_URI += " \
> > > > file://0001-_distutils-sysconfig.py-make-it-possible-to-substite.patch"
> > > >
> > > > -SRC_URI[sha256sum] = "8d243eff56d095e5817f796ede6ae32941278f542e0f941867cc05ae52b162ec"
> > > > +SRC_URI[sha256sum] = "80aacbf633704e9c8bfa1d99fa5dd4dc59573efcf9e4042c13d3bcef91ac2ef9"
> > > >
> > > > DEPENDS += "python3"
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > > >
> > > >
> > > >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#204150): https://lists.openembedded.org/g/openembedded-core/message/204150
> > Mute This Topic: https://lists.openembedded.org/mt/107996505/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >