From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SuLlJ-0005HM-MZ for openembedded-core@lists.openembedded.org; Thu, 26 Jul 2012 12:57:45 +0200 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 26 Jul 2012 03:46:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="177770726" Received: from unknown (HELO helios.localnet) ([10.252.121.37]) by orsmga002.jf.intel.com with ESMTP; 26 Jul 2012 03:46:13 -0700 From: Paul Eggleton To: openembedded-core@lists.openembedded.org Date: Thu, 26 Jul 2012 11:46:13 +0100 Message-ID: <1753997.KifeUqhHux@helios> Organization: Intel Corporation User-Agent: KMail/4.8.4 (Linux/3.2.0-27-generic-pae; KDE/4.8.4; i686; ; ) In-Reply-To: References: <1343297075-29312-1-git-send-email-paul.eggleton@linux.intel.com> <1348620.0mAYnT0NtN@helios> MIME-Version: 1.0 Subject: Re: [PATCH] usbutils: avoid dependency on bash X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2012 10:57:45 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday 26 July 2012 12:42:47 Koen Kooi wrote: > Op 26 jul. 2012, om 12:38 heeft Paul Eggleton het volgende geschreven: > > On Thursday 26 July 2012 12:24:44 Koen Kooi wrote: > >> Op 26 jul. 2012, om 12:04 heeft Paul Eggleton het volgende geschreven: > >>> By virtue of having #!/bin/bash, the usb-devices script declared that it > >>> requires bash, however manual examinasion, checkbashisms and tests with > >>> dash and busybox show that it doesn't contain any bashisms, so change > >>> the script's header and remove the RDEPENDS on bash. > >> > >> Is the update-usbids ash/dash safe as well nowadays? > > > > Manual examination shows no bashisms, checkbashisms reports nothing, and > > it > > works fine with ash here. > > Awesome! Thanks for checking! Since I also made a spelling mistake in the original commit message let me make a v2 also noting that this has been checked as well. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre