public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@kernel.crashing.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/4] tune-cortexa78.inc: Add cortexa78 tune, based on cortexa77
Date: Wed, 31 Jan 2024 20:15:57 -0600	[thread overview]
Message-ID: <1784bb31-b573-4fb1-8ab7-6bee719e7071@kernel.crashing.org> (raw)
In-Reply-To: <CAMKF1spTk=-ruCfNpxC12skg=KCLF71NbFUY-xa5qRRHX5PkZg@mail.gmail.com>

It should be the same as the cortexa77.inc file, but say 78..  So I've no 
problems with that change if it's in master.

--Mark

On 1/31/24 8:09 PM, Khem Raj wrote:
> On Wed, Jan 31, 2024 at 3:29 PM Mark Hatle
> <mark.hatle@kernel.crashing.org> wrote:
>>
>> From: Mark Hatle <mark.hatle@amd.com>
>>
>> Signed-off-by: Mark Hatle <mark.hatle@amd.com>
>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
>> ---
>>   .../include/arm/armv8-2a/tune-cortexa78.inc      | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>   create mode 100644 meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>>
>> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>> new file mode 100644
>> index 0000000000..8c85d98ef9
>> --- /dev/null
>> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa78.inc
>> @@ -0,0 +1,16 @@
>> +#
>> +# Tune Settings for Cortex-A78
>> +#
>> +DEFAULTTUNE                                        ?= "cortexa78"
>> +
>> +TUNEVALID[cortexa78] = "Enable Cortex-A78 specific processor optimizations"
>> +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa78', ' -mcpu=cortex-a78', '', d)}"
>> +
>> +require conf/machine/include/arm/arch-armv8-2a.inc
>> +
>> +# Little Endian base configs
>> +AVAILTUNES                                         += "cortexa78"
>> +ARMPKGARCH:tune-cortexa78                           = "cortexa78"
>> +TUNE_FEATURES:tune-cortexa78                        = "${TUNE_FEATURES:tune-armv8-2a-crypto} cortexa78"
> 
> I think this should be set to "aarch64 crypto cortexa78" inline with
> patch I sent last week [1], otherwise it looks ok.
> 
> [1] https://lore.kernel.org/openembedded-core/20240126233141.1589013-1-raj.khem@gmail.com/
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#194545): https://lists.openembedded.org/g/openembedded-core/message/194545
> Mute This Topic: https://lists.openembedded.org/mt/104086355/3616948
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mark.hatle@kernel.crashing.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


  reply	other threads:[~2024-02-01  2:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 23:29 [PATCH 0/4] Updates for ARM tunings Mark Hatle
2024-01-31 23:29 ` [PATCH 1/4] tune-cortexa78.inc: Add cortexa78 tune, based on cortexa77 Mark Hatle
2024-02-01  2:09   ` [OE-core] " Khem Raj
2024-02-01  2:15     ` Mark Hatle [this message]
2024-01-31 23:29 ` [PATCH 2/4] feature-arm-vfp.inc: Allow hard-float on newer simd targets Mark Hatle
2024-01-31 23:29 ` [PATCH 3/4] tune-cortexr5: Add hard-float variant Mark Hatle
2024-01-31 23:29 ` [PATCH 4/4] tune-cortexr52: " Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1784bb31-b573-4fb1-8ab7-6bee719e7071@kernel.crashing.org \
    --to=mark.hatle@kernel.crashing.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox