Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] buildhistory: reduce the numeric delta to 10%
Date: Mon, 30 Jul 2012 13:22:29 +0100	[thread overview]
Message-ID: <1791255.KrCA1u10OF@helios> (raw)
In-Reply-To: <1343650687-2307-2-git-send-email-ross.burton@intel.com>

On Monday 30 July 2012 13:18:07 Ross Burton wrote:
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/lib/oe/buildhistory_analysis.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/buildhistory_analysis.py
> b/meta/lib/oe/buildhistory_analysis.py index d0e0808..0a50432 100644
> --- a/meta/lib/oe/buildhistory_analysis.py
> +++ b/meta/lib/oe/buildhistory_analysis.py
> @@ -23,7 +23,7 @@ numeric_fields = ['PKGSIZE', 'IMAGESIZE']
>  # Fields to monitor
>  monitor_fields = ['RDEPENDS', 'RRECOMMENDS', 'PACKAGES', 'FILELIST',
> 'PKGSIZE', 'IMAGESIZE'] # Percentage change to alert for numeric fields
> -monitor_numeric_threshold = 20
> +monitor_numeric_threshold = 10
>  # Image files to monitor (note that image-info.txt is handled separately)
>  img_monitor_files = ['installed-package-names.txt', 'files-in-image.txt']
>  # Related context fields for reporting (note: PE, PV & PR are always
> reported for monitored package fields)

I don't think I picked 20% completely out of thin air but I wasn't especially 
scientific about it either, so:

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2012-07-30 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 12:18 [PATCH 1/2] buildhistory: correctly handle reductions of numeric fields Ross Burton
2012-07-30 12:18 ` [PATCH 2/2] buildhistory: reduce the numeric delta to 10% Ross Burton
2012-07-30 12:22   ` Paul Eggleton [this message]
2012-07-30 12:25     ` Burton, Ross
2012-07-30 12:20 ` [PATCH 1/2] buildhistory: correctly handle reductions of numeric fields Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1791255.KrCA1u10OF@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox