Re: [PATCH v2 3/3] machine: include: arm: simplify conditional operations with bb.utils.filter

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi João,

On 4/27/26 3:08 PM, João Marcos Costa wrote:
> Some configuration files use bb.utils.contains to check for a string
> inside a variable, and return the exact same string if true.
> 
> This can be simplified by a call to bb.utils.filter, since the result is
> the same, and the inline is shorter.
> 
> Replace "bb.utils.contains(A, 'a', 'a', '', d)" by "bb.utils.filter(A, 'a', d)".
> 
> bb.utils.filter() does not return the string with a leading space, and
> this is handled by a leading space outside of the helper. This
> workaround, however, has its limitations: the leading space is always
> added. To avoid any potential issues, use .strip() when dereferencing
> TUNE_CCARGS_MFPU in the if statements.
> 

I'm not sure this is worth it as this pattern means next time we add a 
new tunefeatures we'll likely follow the same pattern. This means that 
even though the existing machines won't set this new tunefeature, 
they'll likely rebuild a few things because TUNE_CCARGS_MFPU will have 
an additional space in it (but maybe BitBake parsing is smart enough to 
realize that only

TUNE_CCARGS, ARMPKGSFX_FPU and TUNE_CCARGS_MFLOAT use it and they won't 
change if there's only one space difference, so:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin