Re: [PATCH 1/4] systemd: add ukify packageconfig

[Tan Siewert <tan.siewert@9elements.com>]

On 10/23/26 1:34 PM, Paul Barker wrote:
> On Fri, 2026-10-23 at 12:51 +0200, Tan Siewert wrote:
>> systemd gates ukify via allowed(), so it is built and installed unless
>> explicitly disabled.
>>
>> Add a packageconfig option that is enabled by default when the efi
>> DISTRO_FEATURE is set. It can still be removed if wanted, which may be
>> useful when using meta-tpm, which may include ukify implicitly.
>>
>> Signed-off-by: Tan Siewert <tan.siewert@9elements.com>
> 
> [snip]
> 
>> @@ -405,7 +407,7 @@ PACKAGE_BEFORE_PN += "\
>>       ${PN}-networkd \
>>       ${PN}-rpm-macros \
>>       ${PN}-udev-rules \
>> -    ${PN}-ukify \
>> +    ${@bb.utils.contains('PACKAGECONFIG', 'ukify', '${PN}-ukify', '', d)} \
> 
> Does the package really need to be removed here? If it is empty then
> do_package should not create it. If there are still files that would
> otherwise end up in ${PN}-ukify then removing the package entry may
> cause them to be silently included in a later package.
> 

Sorry for the late response.

Probably not. I may have overlooked it when checking the logs if 
do_package built an empty package or not (and I didn't think about the 
side-effects of it that you describe).

I'll remove the condition in v2.

Thanks!
Tan