From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] mesa: Disable asm on musl
Date: Wed, 03 Oct 2018 10:19:00 +1300 [thread overview]
Message-ID: <1845499.TvibjpggTz@localhost.localdomain> (raw)
In-Reply-To: <CAMKF1sq4xUqHtSVOB_C8Gt6Op_6MNmjrxxEzGTtC5R1eoT4MPw@mail.gmail.com>
Can we have bit more detail in the commit message about what the issues are?
We're not supposed to rely solely on a bug report reference to do that; also
if it's considered a workaround and we're working with upstream to fix it, the
commit message should state that as well.
Thanks
Paul
On Wednesday, 3 October 2018 8:37:10 AM NZDT Khem Raj wrote:
> I think it is. The way th calls are set for performance reasons seems to be
> causing this
> Ideally we should ensure to use right dialect for tls calls I think musl
> is exposing a bug in Mesa
> Which we covered by disabling tls in Glx once we disable that then this
> problem pops up so we disable ASM
>
> So this is a workaround until then
>
> On Tue, Oct 2, 2018 at 12:28 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> > Isn't this a bit overkill? Is the assembler actually broken?
> >
> > Ross
> > On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > some unknown part of mesa's x86 assembly
> > > code is broken by readonly text segments
> > >
> > > [ YOCTO #12918 ]
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > > meta/recipes-graphics/mesa/mesa.inc | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-graphics/mesa/mesa.inc
> > b/meta/recipes-graphics/mesa/mesa.inc
> > > index 8d0e2cb67c..e6f3712706 100644
> > > --- a/meta/recipes-graphics/mesa/mesa.inc
> > > +++ b/meta/recipes-graphics/mesa/mesa.inc
> > > @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] =
> > "--enable-${OSMESA},--disable-${OSMESA}"
> > > PACKAGECONFIG[unwind] =
> > "--enable-libunwind,--disable-libunwind,libunwind"
> > >
> > > EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
> > > -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
> > > +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
> > > # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
> > > FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
> > >
> > > --
> > > 2.19.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
>
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2018-10-02 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 19:11 [PATCH] mesa: Disable asm on musl Khem Raj
2018-10-02 19:27 ` Burton, Ross
2018-10-02 19:37 ` Khem Raj
2018-10-02 20:42 ` Burton, Ross
2018-10-02 20:58 ` Khem Raj
2018-10-02 21:19 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1845499.TvibjpggTz@localhost.localdomain \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox