From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Andreas Müller" <schnitzeltony@googlemail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] buildhistory.bbclass: add pkg_pre/postinst/rm contents
Date: Mon, 28 May 2012 14:19:26 +0100 [thread overview]
Message-ID: <1887160.WQ6ARfi1jf@helios> (raw)
In-Reply-To: <1338143382-5982-1-git-send-email-schnitzeltony@googlemail.com>
On Sunday 27 May 2012 20:29:42 Andreas Müller wrote:
> A use-case would have been [1].
>
> The following tests were performed:
> * image from scratch with old buildhistory contents
> * image from scratch with buildhistory contents from scratch
> * decrement a PR for a test recipe and check if the message
> 'ERROR: Package version for xy went backwards' is displayed.
>
> [1] http://patches.openembedded.org/patch/28841/
FWIW I hadn't forgotten about this feature request, although I hadn't got
around to implementing it yet.
I haven't tested your patch but if I read it correctly you are writing the
scripts out underneath the "value =" lines in the package data file. My concern
with doing this is that it makes those files more difficult to parse. I had
thought that the way to do it would be to write these scripts to separate files
(e.g. latest.pkg_prerm, latest.pkg_postrm etc.). Would that be OK?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2012-05-28 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 18:29 [PATCH] buildhistory.bbclass: add pkg_pre/postinst/rm contents Andreas Müller
2012-05-28 13:19 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1887160.WQ6ARfi1jf@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=schnitzeltony@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox