From: "Guðni Már Gilbert" <gudni.m.g@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3] bluez5: upgrade 5.72 -> 5.77
Date: Tue, 16 Jul 2024 04:01:57 -0700 [thread overview]
Message-ID: <19409.1721127717782088316@lists.openembedded.org> (raw)
In-Reply-To: <22262.1721064263985592663@lists.openembedded.org>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
A bit off topic but, wanted to share something I'm thinking about:
Am wondering about one section in the do_install:append . Not sure if we should remove it or not? It feels wrong to keep referencing Python 2 at least:
# Patch python tools to use Python 3; they should be source compatible, but
# still refer to Python 2 in the shebang
sed -i -e '1s,#!.*python.*,#!${bindir}/python3,' ${D}${libdir}/bluez/test/*
Previously, the shebangs were very inconsistent and usually used /usr/bin/python
But today, they are consistently set to *usr/bin/env python3* , I didn't see this symlink in my testing so I'm not sure if removing this section from do_install is OK.
Thoughts?
[-- Attachment #2: Type: text/html, Size: 942 bytes --]
next prev parent reply other threads:[~2024-07-16 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 17:21 [PATCH v3] bluez5: upgrade 5.72 -> 5.77 Guðni Már Gilbert
2024-07-15 17:24 ` Guðni Már Gilbert
2024-07-16 11:01 ` Guðni Már Gilbert [this message]
2024-07-16 11:03 ` [OE-core] " Alexander Kanavin
2024-07-16 13:10 ` Guðni Már Gilbert
2024-07-16 16:03 ` Guðni Már Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19409.1721127717782088316@lists.openembedded.org \
--to=gudni.m.g@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox