Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v3] guile: added runtime dependency on glibc-gconv-iso8859-1
Date: Thu, 30 May 2013 14:52:50 +0100	[thread overview]
Message-ID: <1956799.LN9zTEVmsc@helios> (raw)
In-Reply-To: <1369834810-18927-1-git-send-email-bogdan.a.marinescu@intel.com>

On Wednesday 29 May 2013 16:40:10 Bogdan Marinescu wrote:
> guile needs to be able to convert strings from ISO-8859-1 in order
> to work properly. This patch adds a runtime dependency to the required
> convert package, but only when glibc is used. The fix for uClibc depends
> on another bug (#4530).
> 
> [YOCTO #4019]
> 
> Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com>
> ---
>  meta/recipes-devtools/guile/guile_2.0.9.bb |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/guile/guile_2.0.9.bb
> b/meta/recipes-devtools/guile/guile_2.0.9.bb index 617f7ce..8ba7afc 100644
> --- a/meta/recipes-devtools/guile/guile_2.0.9.bb
> +++ b/meta/recipes-devtools/guile/guile_2.0.9.bb
> @@ -27,7 +27,7 @@ SRC_URI = "${GNU_MIRROR}/guile/guile-${PV}.tar.xz \
>  SRC_URI[md5sum] = "a69b575d4a633bdd9118f3a4a1e97766"
>  SRC_URI[sha256sum] =
> "f70a38c8d9751f442679bfe61852bba8545af4d4355d037630997c2f37f2895b"
> 
> -PR = "r0"
> +PR = "r1"
> 
>  inherit autotools gettext
>  BBCLASSEXTEND = "native"
> @@ -36,6 +36,9 @@ DEPENDS = "libunistring bdwgc gmp libtool libffi"
>  # add guile-native only to the target recipe's DEPENDS
>  DEPENDS += "${@['guile-native libatomics-ops', ''][d.getVar('PN', True) !=
> 'guile']}"
> 
> +RDEPENDS_${PN}_append_libc-glibc_class-target = "glibc-gconv-iso8859-1"
> +RDEPENDS_${PN}_class-native = ""

The second line is erroneous, surely we only need the first to solve this 
issue?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2013-05-30 13:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 13:40 [PATCH v3] guile: added runtime dependency on glibc-gconv-iso8859-1 Bogdan Marinescu
2013-05-30 13:52 ` Paul Eggleton [this message]
2013-05-30 20:01   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1956799.LN9zTEVmsc@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=bogdan.a.marinescu@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox