From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Ed Bartosh <ed.bartosh@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] populate_sdk_ext: get NATIVELSBSTRING variable
Date: Wed, 14 Dec 2016 08:44:16 +1300 [thread overview]
Message-ID: <1976647.jAKzAtoRFl@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1481648749-25726-1-git-send-email-ed.bartosh@linux.intel.com>
Hi Ed,
On Tue, 13 Dec 2016 19:05:49 Ed Bartosh wrote:
> Setting fixedlsbstring to 'universal' can break populate_sdk_ext
> task as NATIVELSBSTRING can be set to universal-<gcc version> in
> some cases.
>
> Getting NATIVELSBSTRING value using getVar should fix this.
>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> meta/classes/populate_sdk_ext.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_ext.bbclass
> b/meta/classes/populate_sdk_ext.bbclass index 3c3a73c..6ef48c0 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -374,8 +374,8 @@ python copy_buildsystem () {
>
> sstate_out = baseoutpath + '/sstate-cache'
> bb.utils.remove(sstate_out, True)
> - # uninative.bbclass sets NATIVELSBSTRING to 'universal'
> - fixedlsbstring = 'universal'
> +
> + fixedlsbstring = d.getVar('NATIVELSBSTRING', True)
>
> sdk_include_toolchain = (d.getVar('SDK_INCLUDE_TOOLCHAIN', True) ==
> '1') sdk_ext_type = d.getVar('SDK_EXT_TYPE', True)
Have you tested this with OE-Core alone or any other configuration where
uninative is not enabled? I suspect it won't work with that.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2016-12-13 19:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 7:10 [PATCH v2] uninative: rebuild uninative for gcc 4.8 and 4.9 Ed Bartosh
2016-10-31 20:11 ` Burton, Ross
2016-11-08 8:11 ` Ed Bartosh
2016-12-05 10:56 ` Burton, Ross
2016-12-13 17:05 ` [PATCH] populate_sdk_ext: get NATIVELSBSTRING variable Ed Bartosh
2016-12-13 19:44 ` Paul Eggleton [this message]
2016-12-13 23:55 ` [PATCH v3] uninative: rebuild uninative for gcc 4.8 and 4.9 Ed Bartosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1976647.jAKzAtoRFl@peggleto-mobl.ger.corp.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox