Re: [PATCH][V2] u-boot: state the MACHINE when skipping u-boot

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 01 August 2013 17:52:13 Laszlo Papp wrote:
> On Thu, Aug 1, 2013 at 5:50 PM, Otavio Salvador 
<otavio@ossystems.com.br>wrote:
> > On Thu, Aug 1, 2013 at 1:38 PM, Laszlo Papp <lpapp@kde.org> wrote:
> > > On Thu, Aug 1, 2013 at 5:35 PM, Burton, Ross <ross.burton@intel.com>
> > 
> > wrote:
> > >> On 1 August 2013 17:33, Laszlo Papp <lpapp@kde.org> wrote:
> > >> >> I'm not sure what you meant here.  Do you mean a situation where the
> > >> >> local.conf says MACHINE=foo and the user also sets MACHINE=foo in
> > >> >> the
> > >> >> environment?
> > >> > 
> > >> > Yes.
> > >> 
> > >> But there's nothing wrong with the user doing that at all.
> > > 
> > > Why do you think compilers warn in such use cases? Because they cannot
> > 
> > know
> > 
> > > if you are doing something silly, or something unintentional. It might
> > 
> > just
> > 
> > > well be that the user wanted to type something else, but got confused in
> > > which case he might get a hard to debug issue later, or even if not
> > 
> > hard, it
> > 
> > > is additional issue due to his.
> > 
> > Please provide the message you preferred so it can be seen and
> > discussed. An example might make it easier to get what you really
> > mean.
> 
> "Warning: "foo", specified manually on the command line, is the same as in
> the /path/to/the/relevant/background/file.stuff file"
> 
> Please do not hang on the grammar as I am a non-native speakers.

I'm afraid this is not practical. The ability to specify the value for MACHINE 
and other variables from the external environment is not just there for folks 
running bitbake manually from the command line, but also external scripts as 
well, and they could quite legitimately set it to the same value that has been 
specified in the configuration file and showing a warning in that case would be 
undesirable.

I'm not sure I understand the value of showing this warning in any case. The 
system is not going to do anything that the user won't expect - the user 
specified the value of MACHINE on the command line and that's the value that is 
being used. The fact that it is the same as what's in the configuration file is 
incidental.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre